From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8BDAC433ED for ; Tue, 11 May 2021 10:45:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 492CE615FF for ; Tue, 11 May 2021 10:45:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 492CE615FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 906376B0036; Tue, 11 May 2021 06:45:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A3C76B0071; Tue, 11 May 2021 06:45:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76B9E6B0072; Tue, 11 May 2021 06:45:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 5E0BC6B0036 for ; Tue, 11 May 2021 06:45:43 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1214AA77A for ; Tue, 11 May 2021 10:45:43 +0000 (UTC) X-FDA: 78128619366.38.B6D8258 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf14.hostedemail.com (Postfix) with ESMTP id 78CFEC001C62 for ; Tue, 11 May 2021 10:45:18 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4F930AFEB; Tue, 11 May 2021 10:45:41 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id BA5761F2B6D; Tue, 11 May 2021 12:45:40 +0200 (CEST) Date: Tue, 11 May 2021 12:45:40 +0200 From: Jan Kara To: Chi Wu Cc: jack@suse.cz, akpm@linux-foundation.org, axboe@fb.com, hcochran@kernelspring.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mszeredi@redhat.com, sedat.dilek@gmail.com, tj@kernel.org Subject: Re: [PATCH v2] mm/page-writeback: Update the comment of Dirty position control Message-ID: <20210511104540.GJ24154@quack2.suse.cz> References: <20210511090632.GH24154@quack2.suse.cz> <20210511103606.3732-1-wuchi.zero@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210511103606.3732-1-wuchi.zero@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of jack@suse.cz designates 195.135.220.15 as permitted sender) smtp.mailfrom=jack@suse.cz X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 78CFEC001C62 X-Stat-Signature: 1f8bzizakebdgbdcoexoibw3fjq8cs4r Received-SPF: none (suse.cz>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1620729918-290988 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 11-05-21 18:36:06, Chi Wu wrote: > As the value of pos_ratio_polynom() clamp between 0 and > 2LL << RATELIMIT_CALC_SHIFT, the global control line should be > consistent with it. > > Signed-off-by: Chi Wu Thanks! Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/page-writeback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 0062d5c57d41..3882405dc051 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -845,7 +845,7 @@ static long long pos_ratio_polynom(unsigned long setpoint, > * ^ pos_ratio > * | > * | |<===== global dirty control scope ======>| > - * 2.0 .............* > + * 2.0 * * * * * * * > * | .* > * | . * > * | . * > -- > 2.17.1 > -- Jan Kara SUSE Labs, CR