From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 874A7C433B4 for ; Mon, 10 May 2021 20:13:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 060506147F for ; Mon, 10 May 2021 20:13:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 060506147F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1F6D76B0070; Mon, 10 May 2021 16:13:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A6C76B0071; Mon, 10 May 2021 16:13:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 047516B0072; Mon, 10 May 2021 16:13:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id D83236B0070 for ; Mon, 10 May 2021 16:13:04 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8520875B5 for ; Mon, 10 May 2021 20:13:04 +0000 (UTC) X-FDA: 78126420288.30.F6313F5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id B28E780193BA for ; Mon, 10 May 2021 20:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=Av10VQK0cWDtBZkWDT+sFT3o0hxbN01FBpT7/7EgVmU=; b=pqle9OdGTq4YUSz5vuovTaxWDe 3Ej5WR7cvvqJbUv+3XK4qTqo0qQUlrCWMgFWyPi2WFcQPzkUpVs344v5Tewj3eNpBvMzjNpuSarGz 4ljgTdRxcF9zVhkjOKDlAy8WkL2dfCwROwgxP4tzxCIYLjfiLaJpybWj1MPaX6snt68X3awafReNl mTvpcDhFnJM3xYvHLlTZ6VLwBhRSOzU6SJtaQtgyFX/JdCr4lfjse6zQv+Sz8WU5+nfcMM2+8/uVu dt6wAtPLouz1YdaMLGt8iOWWFkZ209dTorbtNg4HLQWgfBFyKv7j5J0MWtaSs4PRxMT8AddHk6kyQ j0DdLmFQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lgCG3-006XZk-JS; Mon, 10 May 2021 20:12:28 +0000 From: "Matthew Wilcox (Oracle)" To: akpm@linux-foundation.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: [PATCH] mm/filemap: Fix readahead return types Date: Mon, 10 May 2021 21:12:01 +0100 Message-Id: <20210510201201.1558972-1-willy@infradead.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Rspamd-Queue-Id: B28E780193BA Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pqle9OdG; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: 6yrpme7yisy8ctkopaij67zomg6hqgnu Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620677572-100344 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: A readahead request will not allocate more memory than can be represented by a size_t, even on systems that have HIGHMEM available. Change the length functions from returning an loff_t to a size_t. Signed-off-by: Matthew Wilcox (Oracle) --- fs/iomap/buffered-io.c | 4 ++-- include/linux/pagemap.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index f2cd2034a87b..9023717c5188 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -394,7 +394,7 @@ void iomap_readahead(struct readahead_control *rac, c= onst struct iomap_ops *ops) { struct inode *inode =3D rac->mapping->host; loff_t pos =3D readahead_pos(rac); - loff_t length =3D readahead_length(rac); + size_t length =3D readahead_length(rac); struct iomap_readpage_ctx ctx =3D { .rac =3D rac, }; @@ -402,7 +402,7 @@ void iomap_readahead(struct readahead_control *rac, c= onst struct iomap_ops *ops) trace_iomap_readahead(inode, readahead_count(rac)); =20 while (length > 0) { - loff_t ret =3D iomap_apply(inode, pos, length, 0, ops, + ssize_t ret =3D iomap_apply(inode, pos, length, 0, ops, &ctx, iomap_readahead_actor); if (ret <=3D 0) { WARN_ON_ONCE(ret =3D=3D 0); diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index a4bd41128bf3..e89df447fae3 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -997,9 +997,9 @@ static inline loff_t readahead_pos(struct readahead_c= ontrol *rac) * readahead_length - The number of bytes in this readahead request. * @rac: The readahead request. */ -static inline loff_t readahead_length(struct readahead_control *rac) +static inline size_t readahead_length(struct readahead_control *rac) { - return (loff_t)rac->_nr_pages * PAGE_SIZE; + return rac->_nr_pages * PAGE_SIZE; } =20 /** @@ -1024,7 +1024,7 @@ static inline unsigned int readahead_count(struct r= eadahead_control *rac) * readahead_batch_length - The number of bytes in the current batch. * @rac: The readahead request. */ -static inline loff_t readahead_batch_length(struct readahead_control *ra= c) +static inline size_t readahead_batch_length(struct readahead_control *ra= c) { return rac->_batch_count * PAGE_SIZE; } --=20 2.30.2