From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62871C433ED for ; Tue, 11 May 2021 01:52:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B815161554 for ; Tue, 11 May 2021 01:52:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B815161554 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 273756B006E; Mon, 10 May 2021 21:52:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 24AA86B0071; Mon, 10 May 2021 21:52:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1128A6B0072; Mon, 10 May 2021 21:52:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id E9FB56B006E for ; Mon, 10 May 2021 21:52:40 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A679C181AF5FD for ; Tue, 11 May 2021 01:52:40 +0000 (UTC) X-FDA: 78127276080.18.38C3801 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf28.hostedemail.com (Postfix) with ESMTP id 19E942000241 for ; Tue, 11 May 2021 01:52:38 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C50D86147E; Tue, 11 May 2021 01:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1620697959; bh=425hPXrffouqTBt0PqY0MyZ5g9I8atvZ2WoYdvxm/Ng=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lFoZy9GgAJysOT6TX+G66+vJiH0SuYwyqKFvag7rZG8OVGWmnAmjzvqSkUmb64maF 4DFAKtX/LiJqnxHD5wkzykY0N14v7idlf+WeYNK+H6hnIL66Sf9IjNFtnxaAKFcFRS tb9Vxj3w6W5dwjDkOiQYsBnQoH4nfGt3qXlgXFL8= Date: Mon, 10 May 2021 18:52:38 -0700 From: Andrew Morton To: Uladzislau Rezki Cc: Matthew Wilcox , linux-mm@kvack.org, LKML , Nicholas Piggin , Mel Gorman , Hillf Danton , Michal Hocko , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH v2 2/2] mm/vmalloc: Print a warning message first on failure Message-Id: <20210510185238.787adc7378bc6d82262399d2@linux-foundation.org> In-Reply-To: <20210510103342.GA2169@pc638.lan> References: <20210509193844.2562-1-urezki@gmail.com> <20210509193844.2562-2-urezki@gmail.com> <20210509200519.GA3016@pc638.lan> <20210509212641.GA3220@pc638.lan> <20210510103342.GA2169@pc638.lan> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 19E942000241 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lFoZy9Gg; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam03 X-Stat-Signature: b5ywcnrsn9k8qhuosbysm9eo5o9frfj6 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620697958-521738 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 10 May 2021 12:33:42 +0200 Uladzislau Rezki wrote: > Please find the v4 version of the patch that is in question: > > >From 7e27e4ac8f299ae244e9e0e90e0292ae2c08d37d Mon Sep 17 00:00:00 2001 > From: "Uladzislau Rezki (Sony)" > Date: Sat, 8 May 2021 23:41:21 +0200 > Subject: [PATCH v4 1/1] mm/vmalloc: Print a warning message first on failure Added, thanks. Matthew has a point of course, but I do think that any console driver which tries to allocate memory within the cotext of printk() is so pathetic that it isn't worth compromising core code to cater for it...