From: Oscar Salvador <osalvador@suse.de>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-mm@kvack.org, akpm@linux-foundation.org,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/thp: Make ARCH_ENABLE_SPLIT_PMD_PTLOCK dependent on PGTABLE_LEVELS > 2
Date: Mon, 10 May 2021 12:10:07 +0200 [thread overview]
Message-ID: <20210510101006.GB22664@linux> (raw)
In-Reply-To: <843e545a-ca0c-6a1e-2ab0-28ccca182400@arm.com>
On Mon, May 10, 2021 at 03:36:29PM +0530, Anshuman Khandual wrote:
>
>
> On 5/10/21 2:23 PM, Peter Zijlstra wrote:
> > On Mon, May 10, 2021 at 10:05:45AM +0530, Anshuman Khandual wrote:
> >> - select ARCH_ENABLE_SPLIT_PMD_PTLOCK if X86_64 || X86_PAE
> >> + select ARCH_ENABLE_SPLIT_PMD_PTLOCK if (PGTABLE_LEVELS > 2) && (X86_64 || X86_PAE)
> >
> > It's still very early on a Monday, but IIRC this new condition is
> > identical to the pre-existing one.
>
> Did not get it, could you please elaborate ?
When using x86_PAE, you must have more than two pgtable levels, right?
And not speaking of x86_64.
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2021-05-10 10:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 4:35 Anshuman Khandual
2021-05-10 8:53 ` Peter Zijlstra
2021-05-10 10:06 ` Anshuman Khandual
2021-05-10 10:10 ` Oscar Salvador [this message]
2021-05-10 10:16 ` Anshuman Khandual
2021-05-10 11:51 ` Anshuman Khandual
[not found] ` <a4403be6-5b74-2c86-bc4c-42ae4f0764dc@arm.com>
2021-05-17 14:13 ` Gerald Schaefer
2021-05-19 11:07 ` Gerald Schaefer
2021-05-24 9:41 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510101006.GB22664@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox