From: Andrew Morton <akpm@linux-foundation.org>
To: glittao@gmail.com
Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, vbabka@suse.cz,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/slub: use stackdepot to save stack trace in objects
Date: Sun, 9 May 2021 21:46:03 -0700 [thread overview]
Message-ID: <20210509214603.d2a5faaa3fe0d71c3517cb36@linux-foundation.org> (raw)
In-Reply-To: <20210414163434.4376-1-glittao@gmail.com>
On Wed, 14 Apr 2021 18:34:34 +0200 glittao@gmail.com wrote:
> Many stack traces are similar so there are many similar arrays.
> Stackdepot saves each unique stack only once.
>
> Replace field addrs in struct track with depot_stack_handle_t handle.
> Use stackdepot to save stack trace.
>
> The benefits are smaller memory overhead and possibility to aggregate
> per-cache statistics in the future using the stackdepot handle
> instead of matching stacks manually.
Which tree was this prepared against? 5.12's kmem_obj_info() is
significantly different from the version you were working on.
Please take a look, redo, retest and resend? Thanks.
next prev parent reply other threads:[~2021-05-10 4:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210414163434.4376-1-glittao@gmail.com>
2021-04-20 16:58 ` Vlastimil Babka
2021-04-26 1:10 ` David Rientjes
2021-05-10 4:46 ` Andrew Morton [this message]
2021-05-12 14:33 ` Vlastimil Babka
2021-05-13 0:07 ` Andrew Morton
2021-05-16 19:51 ` [PATCH] mm/slub: use stackdepot to save stack trace in objects-fix Vlastimil Babka
2021-07-02 15:37 ` [PATCH] mm/slub: use stackdepot to save stack trace in objects Guenter Roeck
2021-07-02 16:01 ` Vlastimil Babka
2021-07-13 12:03 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210509214603.d2a5faaa3fe0d71c3517cb36@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=glittao@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox