From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,MIME_QP_LONG_LINE,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7C1AC433B4 for ; Sat, 8 May 2021 17:51:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6BD1A61421 for ; Sat, 8 May 2021 17:51:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BD1A61421 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9E81E6B0070; Sat, 8 May 2021 13:51:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9974E6B0073; Sat, 8 May 2021 13:51:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 837046B0074; Sat, 8 May 2021 13:51:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id 682616B0070 for ; Sat, 8 May 2021 13:51:35 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1D240181AF5C3 for ; Sat, 8 May 2021 17:51:35 +0000 (UTC) X-FDA: 78118806150.16.70BCB55 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf24.hostedemail.com (Postfix) with ESMTP id 56367A0000FA for ; Sat, 8 May 2021 17:51:21 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 510B660FD9; Sat, 8 May 2021 17:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620496293; bh=O0h+6YLIy3dP7dPfFuX77EmGOJ47Y0nxessyteHlFwI=; h=Date:In-Reply-To:References:Subject:To:CC:From:From; b=BgjMRsti57RVhgQLssViPv/S1jke0ZLAX2VHcQ+zhhqyTEdCGfsx+Hm+xfLYc3gK2 febH6fPKLW1GSvaeOKdWLiFT7mRIPWWr75WERrbhc2iP5XTwEvaWUeT5C35mmGej+K 2PcdNk2F7zAnv7ool7i0GQtmQlR0QvCGCi54y4VUmuqProi5oDD31BiSBZqMLtCS+M dWjPvGC1v25ePTrlu9IDnx7VhIslSf3ux2o+IJF65VRAkOiztZHjJqudkvMw1FjRre H5PnmFZFJ4SyMu1vYvNmyyo21lFpuMxuRrcIpAD5pLR8VMdJxDTCRJjWYRX6B4pi1c 1jcXpeCGiqVyA== Date: Sat, 08 May 2021 20:51:23 +0300 User-Agent: K-9 Mail for Android In-Reply-To: References: <20210420150049.14031-1-rppt@kernel.org> <20210420150049.14031-3-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v3 2/2] secretmem: optimize page_is_secretmem() To: Matthew Wilcox CC: Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dan Williams , Dave Hansen , David Hildenbrand , Elena Reshetova , "H. Peter Anvin" , Ingo Molnar , James Bottomley , "Kirill A. Shutemov" , Matthew Garrett , Mark Rutland , Michal Hocko , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , "Rafael J. Wysocki" , Rick Edgecombe , Roman Gushchin , Shakeel@kvack.org, Butt@kvack.org Message-Id: <20210508175132.510B660FD9@mail.kernel.org> From: rppt@kernel.org X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 56367A0000FA Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BgjMRsti; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Stat-Signature: 1bs3t9ikjpjhxbxyxfajwxq643yb78wq Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620496281-167878 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ,Shuah Khan ,Thomas Gleixner ,Tycho Andersen ,Will Deacon ,Yury Norov ,linux-api@vger.kernel.org,linux-arch@vger.kernel.org,linux-arm-kernel@lists.infradead.org,linux-fsdevel@vger.kernel.org,linux-mm@kvack.org,linux-kernel@vger.kernel.org,linux-kselftest@vger.kernel.org,linux-nvdimm@lists.01.org,linux-riscv@lists.infradead.org,x86@kernel.org,kernel test robot From: Mike Rapoport Message-ID: <48E0FD56-6084-48B0-A59C-D2E2BF40DDA2@kernel.org> On May 7, 2021 6:01:44 PM GMT+03:00, Matthew Wilcox wrote: >On Tue, Apr 20, 2021 at 06:00:49PM +0300, Mike Rapoport wrote: >> + mapping =3D (struct address_space *) >> + ((unsigned long)page->mapping & ~PAGE_MAPPING_FLAGS); >> + >> + if (mapping !=3D page->mapping) >> + return false; >> + >> + return page->mapping->a_ops =3D=3D &secretmem_aops; > >=2E=2E=2E why do you go back to page->mapping here? > > return mapping->a_ops =3D=3D &secretmem_aops Ok --=20 Sincerely yours, Mike