From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D66C5C433B4 for ; Mon, 3 May 2021 07:46:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C64560FEB for ; Mon, 3 May 2021 07:46:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C64560FEB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=norik.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 855596B0036; Mon, 3 May 2021 03:46:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82B8B6B006E; Mon, 3 May 2021 03:46:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CC646B0070; Mon, 3 May 2021 03:46:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id 515A26B0036 for ; Mon, 3 May 2021 03:46:45 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0AA9E181AEF3F for ; Mon, 3 May 2021 07:46:45 +0000 (UTC) X-FDA: 78099137970.03.0250154 Received: from cpanel.siel.si (cpanel.siel.si [46.19.9.99]) by imf05.hostedemail.com (Postfix) with ESMTP id EAAB4E000122 for ; Mon, 3 May 2021 07:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nSFrq9lFNWpRXzhrsu3gsuZbrC0Z5T4HsqbZmtnN6XU=; b=aUU/LAkqBwnF9EP0SXMakNM6Yf tAhiaQx7mu5dsxYzlhtFXnhF572BAXHSfv6Ib7iKoHljuyQx6bAQPs4t5T7A+bxofmi8d2cOu7vRQ KZEJ/JOkBrV3FH0W/ANhn5Mu4ByeCW0Uyyjqys9619oU1P8OS7oFcSM9/DHqusCkPZNNcp1gXXzUu tWIqnit648rtZLIXM3MpXUEqe9rU6GrlnEsw9kyodcaHBUlKCZClZWjctu3PcITd4N2j5ZaVeQCPV HEqEubPGW/r8jqquAJ1a90L0BGQT8eU1M7NnFsl4iP0tgijR7emA4xz0pstaw60rQ0CQefULnJ+Th RLyblc+Q==; Received: from 89-212-21-243.static.t-2.net ([89.212.21.243]:35770 helo=localhost.localdomain) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1ldTHk-002Lfp-Qd; Mon, 03 May 2021 09:46:40 +0200 From: Primoz Fiser To: l.stach@pengutronix.de Cc: akpm@linux-foundation.org, dri-devel@lists.freedesktop.org, dvyukov@google.com, etnaviv@lists.freedesktop.org, huyue2@yulong.com, kernel@pengutronix.de, linux-mm@kvack.org, m.szyprowski@samsung.com, mina86@mina86.com, patchwork-lst@pengutronix.de, thesven73@gmail.com, linux+etnaviv@armlinux.org.uk, s.riedmueller@phytec.de, y.bas@phytec.de, s.mueller-klieser@phytec.de Subject: Re: [PATCH 2/2] drm/etnaviv: use CMA area to compute linear window offset if possible Date: Mon, 3 May 2021 09:46:40 +0200 Message-Id: <20210503074640.3412988-1-primoz.fiser@norik.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20190529104312.27835-2-l.stach@pengutronix.de> References: <20190529104312.27835-2-l.stach@pengutronix.de> MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - kvack.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: primoz.fiser@norik.com X-Authenticated-Sender: cpanel.siel.si: primoz.fiser@norik.com X-Source: X-Source-Args: X-Source-Dir: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=norik.com header.s=default header.b="aUU/LAkq"; dmarc=none; spf=none (imf05.hostedemail.com: domain of primoz.fiser@norik.com has no SPF policy when checking 46.19.9.99) smtp.mailfrom=primoz.fiser@norik.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EAAB4E000122 X-Stat-Signature: zzo534snyisz53d6we1w8bw435im6d6i Received-SPF: none (norik.com>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=cpanel.siel.si; client-ip=46.19.9.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620028000-153873 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, what happened to these patches? In thread "[REGRESSION] drm/etnaviv: comm= and buffer outside valid memory window" [1] it was mentioned these got "shot down" due to layering violations, but no official correspondence has been found? Is is due to exporting symbols from mm/cma.c in [1/2] and why is t= his an issue? We are still affected by issue these patches tried to address and we are interested in getting the solution into mainline. Patches were integrated (small fix required due to renamed include file h= eader) and tested on latest master with PHYTEC's 2GiB phyCORE SoM and cma=3D256M= kernel cmdline parameter. Without patches: [ 7.892954] etnaviv etnaviv: bound 130000.gpu (ops gpu_ops) [ 7.901286] etnaviv etnaviv: bound 134000.gpu (ops gpu_ops) [ 7.909809] etnaviv etnaviv: bound 2204000.gpu (ops gpu_ops) [ 7.915775] etnaviv-gpu 130000.gpu: model: GC2000, revision: 5108 [ 7.924000] etnaviv-gpu 134000.gpu: model: GC320, revision: 5007 [ 7.930615] etnaviv-gpu 2204000.gpu: model: GC355, revision: 1215 [ 7.936934] etnaviv-gpu 2204000.gpu: Ignoring GPU with VG and FE2.0 [ 7.948600] [drm] Initialized etnaviv 1.3.0 20151214 for etnaviv on mi= nor 1 [ 16.656092] etnaviv etnaviv: command buffer outside valid memory windo= w [ 16.695777] etnaviv etnaviv: command buffer outside valid memory windo= w [ 16.765654] etnaviv etnaviv: command buffer outside valid memory windo= w [ 16.800111] etnaviv etnaviv: command buffer outside valid memory windo= w NOTE: See "command buffer outside valid memory window" errors when trying= to use GPU. With patches: [ 7.708159] etnaviv etnaviv: bound 130000.gpu (ops gpu_ops) [ 7.716095] etnaviv etnaviv: bound 134000.gpu (ops gpu_ops) [ 7.724257] etnaviv etnaviv: bound 2204000.gpu (ops gpu_ops) [ 7.730205] etnaviv-gpu 130000.gpu: model: GC2000, revision: 5108 [ 7.738407] etnaviv-gpu 134000.gpu: model: GC320, revision: 5007 [ 7.745039] etnaviv-gpu 2204000.gpu: model: GC355, revision: 1215 [ 7.751365] etnaviv-gpu 2204000.gpu: Ignoring GPU with VG and FE2.0 [ 7.762876] [drm] Initialized etnaviv 1.3.0 20151214 for etnaviv on mi= nor 1 NOTE: No errors, GPU fully functional! In the end, it looks like we are not the only ones with the same issues a= s patch "drm/etnaviv: optionally set gpu linear window to cma area" that addresses the same issue was submitted by Sven Van Asbroeck (see [2]).=20 Unfortunately, his solution was also not accepted. Please advise what would be the best solution implementation and how to proceed in this case? BR, Primoz [1] https://lists.freedesktop.org/archives/dri-devel/2019-June/223516.htm= l [2] https://lore.kernel.org/dri-devel/20190619183856.467-1-TheSven73@gmai= l.com/