From: Maninder Singh <maninder1.s@samsung.com>
To: Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>
Cc: Marco Elver <elver@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
AMIT SAHRAWAT <a.sahrawat@samsung.com>,
Vaneet Narang <v.narang@samsung.com>
Subject: RE:[PATCH 2/2] mm/kasan: proc interface to read KASAN errors at any time
Date: Fri, 30 Apr 2021 15:24:33 +0530 [thread overview]
Message-ID: <20210430095433epcms5p53089199bdd0411193fb9a1154c57a24f@epcms5p5> (raw)
In-Reply-To: <CGME20210422081536epcas5p417c144cce0235933a1cd0f29ad55470a@epcms5p5>
Hi Alex,
>We've recently attempted to build a universal library capturing every
>error report, but then were pointed to tracefs, which was just enough
>for our purpose (https://protect2.fireeye.com/v1/url?k=36bfb191-6924888b-36be3ade-0cc47a6cba04-0e7fd520f09636ee&q=1&e=a6b7f23a-98d4-4084-af0a-a88af0b4c9d0&u=https%3A%2F%2Flkml.org%2Flkml%2F2021%2F1%2F15%2F609).
>Greg also stated that procfs is a bad place for storing reports:
>https://protect2.fireeye.com/v1/url?k=924a3ffc-cdd106e6-924bb4b3-0cc47a6cba04-882467cbf9e8b46f&q=1&e=a6b7f23a-98d4-4084-af0a-a88af0b4c9d0&u=https%3A%2F%2Flkml.org%2Flkml%2F2021%2F1%2F15%2F929.
>
>Maninder, which exactly problem are you trying to solve?
We focussed on 2 problems, 1 is to remove duplicate error reporting
from KASAN when multishot is ON
and second was to save KASAN metadata (minimal) to regenerate same KASAN warnings
when user reads new proc interface.
>Note that KASAN already triggers a trace_error_report_end tracepoint
>on every error report:
>https://protect2.fireeye.com/v1/url?k=2d128c9c-7289b586-2d1307d3-0cc47a6cba04-3e939a06aa0346db&q=1&e=a6b7f23a-98d4-4084-af0a-a88af0b4c9d0&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.12-rc8%2Fsource%2Fmm%2Fkasan%2Freport.c%23L90
>Would it help if you used that one? It could probably be extended with
>more parameters.
>
>Another option if you want verbatim reports is to use the console
>tracepoints, as this is done in
>https://protect2.fireeye.com/v1/url?k=5f368dc2-00adb4d8-5f37068d-0cc47a6cba04-fe4efc4f73dbea2f&q=1&e=a6b7f23a-98d4-4084-af0a-a88af0b4c9d0&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.12-rc8%2Fsource%2Fmm%2Fkfence%2Fkfence_test.c
>Note that there are many caveats with error report collection (see the
>links above), but for testing purpose it might be enough.
>
Ok We will check these tracing methods also.
Thanks
Maninder Singh
parent reply other threads:[~2021-04-30 9:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CGME20210422081536epcas5p417c144cce0235933a1cd0f29ad55470a@epcms5p5>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430095433epcms5p53089199bdd0411193fb9a1154c57a24f@epcms5p5 \
--to=maninder1.s@samsung.com \
--cc=a.sahrawat@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryabinin.a.a@gmail.com \
--cc=v.narang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox