From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 753AFC43462 for ; Wed, 28 Apr 2021 20:39:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E521A6101C for ; Wed, 28 Apr 2021 20:39:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E521A6101C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 65EF56B006E; Wed, 28 Apr 2021 16:39:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60DCD6B0070; Wed, 28 Apr 2021 16:39:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3ED6C6B0072; Wed, 28 Apr 2021 16:39:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id 1DD496B006E for ; Wed, 28 Apr 2021 16:39:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CA384180142FE for ; Wed, 28 Apr 2021 20:39:40 +0000 (UTC) X-FDA: 78082941720.23.9EF4E1D Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf29.hostedemail.com (Postfix) with ESMTP id 53E8C12E for ; Wed, 28 Apr 2021 20:39:36 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id 1DD3011D60 for ; Wed, 28 Apr 2021 20:39:40 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 009BE23810 for ; Wed, 28 Apr 2021 20:39:39 +0000 (UTC) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D6C1E82499A8 for ; Wed, 28 Apr 2021 20:39:29 +0000 (UTC) X-FDA: 78082941258.24.9DB634B Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf17.hostedemail.com (Postfix) with ESMTP id D46FA40002F2 for ; Wed, 28 Apr 2021 20:39:25 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id 5ABFE11D54 for ; Wed, 28 Apr 2021 20:39:29 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 3E4F023810 for ; Wed, 28 Apr 2021 20:39:29 +0000 (UTC) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1DADD181AEF39 for ; Wed, 28 Apr 2021 20:39:19 +0000 (UTC) X-FDA: 78082940838.40.904560F Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf05.hostedemail.com (Postfix) with ESMTP id 6F928E000113 for ; Wed, 28 Apr 2021 20:39:16 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id 766B811CEC for ; Wed, 28 Apr 2021 20:39:18 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 573D723810 for ; Wed, 28 Apr 2021 20:39:18 +0000 (UTC) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 39CE412C1 for ; Wed, 28 Apr 2021 20:39:02 +0000 (UTC) X-FDA: 78082940124.30.118365B Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf26.hostedemail.com (Postfix) with ESMTP id EDA9240002F8 for ; Wed, 28 Apr 2021 20:38:52 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id l10-20020a17090a850ab0290155b06f6267so3558340pjn.5 for ; Wed, 28 Apr 2021 13:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zX+hK2XOLgRiQ/qjPvLplrcpep/+GXekqfv3v8DoP8Y=; b=eznfVr2r6hniEBhA8Ti+a0WaocGIo4MLATqiMl0YuCwQdn7/ROGHFaGBkasECeL9Az fEWErThEPHa5OsYKa0GcUhBcxmaoAxsyjf5VOYBedtZmCOodHSC1O25SKBhGKCK1bySC 7bmHayjv7zY6FC8zKZhK3XrVTNddE6Mi9fQ5A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zX+hK2XOLgRiQ/qjPvLplrcpep/+GXekqfv3v8DoP8Y=; b=W6D1PJQrkHGyV+d99aGZWN0RhT8va3tp/yenG8EqDCPDmqNsGVj7a/WjBt/T7ZdA8m KaPthVyJTHbuYzultg/h3N/KonvD0ctWpK6Z9vkZtBxeFo/3e8HrJsLQGwwfRTPmUOGg wKv5990UWTPCzxWJae+fWhCHlH3TuhJPuAvnauuhlndU6IIrmlQy/U2WqVzCb5YcK9Og Z+CSrzsTVhFH4R6QhW2c5CQkFOBO+Bm5Ss+bmhwUubu58oGJlZ2pO4qQfmV8m9ixVGjf AmYOFOR3SoWhjKIr0+IB9WCCgBxc8OgLrbKukOx2eiM0Xp7Ftl6b2wG7gg4rHjHlFfIk ozcw== X-Gm-Message-State: AOAM53321ysxynU9/KCH329lNhsFxibZkbC+5D69vokEET4BDgbCDfM4 2Xx8C7efC/fnVvSkzWuBMAXlvw== X-Google-Smtp-Source: ABdhPJxyZq7otCKoJchIV/jWvA6R5WarwWjbjwOrFjnZ0XQpOs4C90cIVIy2X5MXomN15cTXzU6s2w== X-Received: by 2002:a17:90b:4017:: with SMTP id ie23mr5716039pjb.155.1619642340911; Wed, 28 Apr 2021 13:39:00 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id k17sm320598pji.47.2021.04.28.13.39.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 13:39:00 -0700 (PDT) Date: Wed, 28 Apr 2021 13:38:59 -0700 From: Kees Cook To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang Subject: Re: [PATCH v26 6/9] x86/vdso: Insert endbr32/endbr64 to vDSO Message-ID: <202104281338.223448FB@keescook> References: <20210427204720.25007-1-yu-cheng.yu@intel.com> <20210427204720.25007-7-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210427204720.25007-7-yu-cheng.yu@intel.com> Received-SPF: none (chromium.org>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mail-pj1-f41.google.com; client-ip=209.85.216.41 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619642332-357292 Received-SPF: none (chromium.org>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619642356-849956 Received-SPF: none (chromium.org>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619642365-512471 X-Stat-Signature: w3jwp8zbuux998qh81uyzqhj9p3mew4s X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 53E8C12E Received-SPF: none (chromium.org>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619642376-402380 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 27, 2021 at 01:47:17PM -0700, Yu-cheng Yu wrote: > From: "H.J. Lu" > > When Indirect Branch Tracking (IBT) is enabled, vDSO functions may be > called indirectly, and must have ENDBR32 or ENDBR64 as the first > instruction. The compiler must support -fcf-protection=branch so that it > can be used to compile vDSO. > > Signed-off-by: H.J. Lu Reviewed-by: Kees Cook -- Kees Cook