From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <ziy@nvidia.com>, <william.kucharski@oracle.com>,
<willy@infradead.org>, <yang.shi@linux.alibaba.com>,
<aneesh.kumar@linux.ibm.com>, <rcampbell@nvidia.com>,
<songliubraving@fb.com>, <kirill.shutemov@linux.intel.com>,
<riel@surriel.com>, <hannes@cmpxchg.org>, <minchan@kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<linmiaohe@huawei.com>
Subject: [PATCH 1/5] mm/huge_memory.c: remove dedicated macro HPAGE_CACHE_INDEX_MASK
Date: Tue, 27 Apr 2021 21:32:10 +0800 [thread overview]
Message-ID: <20210427133214.2270207-2-linmiaohe@huawei.com> (raw)
In-Reply-To: <20210427133214.2270207-1-linmiaohe@huawei.com>
Rewrite the pgoff checking logic to remove macro HPAGE_CACHE_INDEX_MASK
which is only used here to simplify the code.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
include/linux/huge_mm.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
index 9626fda5efce..0a526f211fec 100644
--- a/include/linux/huge_mm.h
+++ b/include/linux/huge_mm.h
@@ -152,15 +152,13 @@ static inline bool __transparent_hugepage_enabled(struct vm_area_struct *vma)
bool transparent_hugepage_enabled(struct vm_area_struct *vma);
-#define HPAGE_CACHE_INDEX_MASK (HPAGE_PMD_NR - 1)
-
static inline bool transhuge_vma_suitable(struct vm_area_struct *vma,
unsigned long haddr)
{
/* Don't have to check pgoff for anonymous vma */
if (!vma_is_anonymous(vma)) {
- if (((vma->vm_start >> PAGE_SHIFT) & HPAGE_CACHE_INDEX_MASK) !=
- (vma->vm_pgoff & HPAGE_CACHE_INDEX_MASK))
+ if (!IS_ALIGNED((vma->vm_start >> PAGE_SHIFT) - vma->vm_pgoff,
+ HPAGE_PMD_NR))
return false;
}
--
2.23.0
next prev parent reply other threads:[~2021-04-27 13:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 13:32 [PATCH 0/5] Cleanup and fixup for huge_memory Miaohe Lin
2021-04-27 13:32 ` Miaohe Lin [this message]
2021-04-27 20:57 ` [PATCH 1/5] mm/huge_memory.c: remove dedicated macro HPAGE_CACHE_INDEX_MASK Yang Shi
2021-04-28 3:04 ` Anshuman Khandual
2021-04-27 13:32 ` [PATCH 2/5] mm/huge_memory.c: use page->deferred_list Miaohe Lin
2021-04-27 20:46 ` Yang Shi
2021-04-28 3:07 ` Anshuman Khandual
2021-04-28 8:23 ` Miaohe Lin
2021-04-27 13:32 ` [PATCH 3/5] mm/huge_memory.c: add missing read-only THP checking in transparent_hugepage_enabled() Miaohe Lin
2021-04-27 21:03 ` Yang Shi
2021-04-28 2:06 ` Miaohe Lin
2021-04-28 16:21 ` Yang Shi
2021-04-29 2:00 ` Miaohe Lin
2021-04-27 13:32 ` [PATCH 4/5] mm/huge_memory.c: remove unnecessary tlb_remove_page_size() for huge zero pmd Miaohe Lin
2021-04-27 13:32 ` [PATCH 5/5] mm/huge_memory.c: don't discard hugepage if other processes are mapping it Miaohe Lin
2021-04-27 21:22 ` Yang Shi
2021-04-28 3:10 ` [PATCH 0/5] Cleanup and fixup for huge_memory Anshuman Khandual
2021-04-28 8:32 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210427133214.2270207-2-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=rcampbell@nvidia.com \
--cc=riel@surriel.com \
--cc=songliubraving@fb.com \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox