From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF3DC433B4 for ; Mon, 26 Apr 2021 22:05:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7461C611BE for ; Mon, 26 Apr 2021 22:05:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7461C611BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A71896B0036; Mon, 26 Apr 2021 18:05:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1F5B6B006E; Mon, 26 Apr 2021 18:05:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86F0D6B0070; Mon, 26 Apr 2021 18:05:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 67ACC6B0036 for ; Mon, 26 Apr 2021 18:05:50 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 23554181AF5E1 for ; Mon, 26 Apr 2021 22:05:50 +0000 (UTC) X-FDA: 78075901260.07.56CECA7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf03.hostedemail.com (Postfix) with ESMTP id E99B6C0007E5 for ; Mon, 26 Apr 2021 22:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619474748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uNz6ov6sR6/KHiccp2YcRtHEiY21v3dtvPylvMBzUpI=; b=aNc27O52RbZ8GaUTMyRXLKbL/SORpT82ZGsFGN0B96BENQLegSMAdKmRiXqdFAFbpsof0s ROKYB2yeCM6T4ltehCI5gir7ycI9Gj9k+pIU73EV6rPJMR778Zopj+loC8dgM0Sh5fHevj UWM7gzk4UGqPyPOu4LoTQyRbqUAK4zg= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-Q8O1Xdx2Pgm6W0Gzsm5Elw-1; Mon, 26 Apr 2021 18:05:46 -0400 X-MC-Unique: Q8O1Xdx2Pgm6W0Gzsm5Elw-1 Received: by mail-qk1-f197.google.com with SMTP id g76-20020a379d4f0000b02902e40532d832so15324049qke.20 for ; Mon, 26 Apr 2021 15:05:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uNz6ov6sR6/KHiccp2YcRtHEiY21v3dtvPylvMBzUpI=; b=j/pELobFV2/G5CEBLH4gTtGFaoH5AJiF0JmuYnUtVgTgfnW/CdyQTz6Sd6BO0FWfnH FYUrNC72bFmJjhhHpiIKYCmIIKGBjHQ7c70HOLKUlVJDS0ltsNmW+1viYLRV93jQU62v oVs5Ttpj1CGq5rhhdP2y5wxAtgAeT5Wz6fI0vxT1hprk7bK2XxF82+/tyltCwXyP9GdI o6GZuxwhABZzq7bF9MYkeTzP9Q+2jg5XwXZaDgWxotcyj2VEhKMRmyM0beiz9WikCkc1 7P/72F3PQU1UfmIm/c/Zq870Qx1/zrcF8fyI4WNOn8ntIc3CzdqUzag9o9eNnVFvaBmp qubQ== X-Gm-Message-State: AOAM531Dkcj8c1iSqsoyqwY5l2jUFFgiIHd9h0yBd8fiSolQsrMF2dbi gOEJX9auUTyat1l6izjCvZ8OJ74gqKCTJCohSWYSFL0NyDYDcEEn/WibunocUbjSlfVevbNp4u0 0cIAX/h8qTys= X-Received: by 2002:a05:620a:381:: with SMTP id q1mr4671858qkm.243.1619474746218; Mon, 26 Apr 2021 15:05:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfRg6ZdHzZYp29cQrm8zjslzvqyrib4coyP0WvWgvrmyIeJ84DHKeppnD4vpeUTW9kG7tEBQ== X-Received: by 2002:a05:620a:381:: with SMTP id q1mr4671836qkm.243.1619474745960; Mon, 26 Apr 2021 15:05:45 -0700 (PDT) Received: from xz-x1 (bras-base-toroon474qw-grc-77-184-145-104-227.dsl.bell.ca. [184.145.104.227]) by smtp.gmail.com with ESMTPSA id 203sm1377590qki.11.2021.04.26.15.05.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 15:05:45 -0700 (PDT) Date: Mon, 26 Apr 2021 18:05:44 -0400 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport , Nadav Amit , Jerome Glisse , Hugh Dickins , Andrea Arcangeli , Andrew Morton , "Kirill A . Shutemov" , Axel Rasmussen , Matthew Wilcox Subject: Re: [PATCH 21/23] hugetlb/userfaultfd: Only drop uffd-wp special pte if required Message-ID: <20210426220544.GI85002@xz-x1> References: <20210323004912.35132-1-peterx@redhat.com> <20210323005054.35973-1-peterx@redhat.com> <02712955-0552-f82a-0ab8-460d63af3519@oracle.com> <20210426211653.GH85002@xz-x1> <1419a8cb-1028-31e8-bae7-4caf79819f02@oracle.com> MIME-Version: 1.0 In-Reply-To: <1419a8cb-1028-31e8-bae7-4caf79819f02@oracle.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E99B6C0007E5 X-Stat-Signature: eydxusaykiji4rgaub3u8smdpz7retp9 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619474743-717241 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 26, 2021 at 02:36:26PM -0700, Mike Kravetz wrote: > On 4/26/21 2:16 PM, Peter Xu wrote: > > On Fri, Apr 23, 2021 at 01:33:08PM -0700, Mike Kravetz wrote: > >> On 3/22/21 5:50 PM, Peter Xu wrote: > >>> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > >>> index 92710600596e..4047fa042782 100644 > >>> --- a/include/linux/hugetlb.h > >>> +++ b/include/linux/hugetlb.h > >>> @@ -121,14 +121,15 @@ long follow_hugetlb_page(struct mm_struct *, struct vm_area_struct *, > >>> unsigned long *, unsigned long *, long, unsigned int, > >>> int *); > >>> void unmap_hugepage_range(struct vm_area_struct *, > >>> - unsigned long, unsigned long, struct page *); > >>> + unsigned long, unsigned long, struct page *, > >>> + unsigned long); > >>> void __unmap_hugepage_range_final(struct mmu_gather *tlb, > >>> struct vm_area_struct *vma, > >>> unsigned long start, unsigned long end, > >>> - struct page *ref_page); > >>> + struct page *ref_page, unsigned long zap_flags); > >>> void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > >>> unsigned long start, unsigned long end, > >>> - struct page *ref_page); > >>> + struct page *ref_page, unsigned long zap_flags); > >> > >> Nothing introduced with your patch, but it seems __unmap_hugepage_range_final > >> does not need to be in the header and can be static in hugetlb.c. > > > > It seems to be used in unmap_single_vma() of mm/memory.c? > > Sorry, that should have been __unmap_hugepage_range. No need for you to > address in this series. Ah yes; I'd rather add a patch if you won't object, since my series will touch that definition. > > >> > >> Everything else looks good, > >> > >> Reviewed-by: Mike Kravetz > > > > Please let me know whether you want my extra paragraph in the commit message, > > then I'll coordinate accordingly with the R-b. Thanks! > > Yes, please do add the extra paragraph. Will do. -- Peter Xu