From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C6E9C433B4 for ; Fri, 23 Apr 2021 19:29:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E0DA261465 for ; Fri, 23 Apr 2021 19:29:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0DA261465 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6BB7F6B0036; Fri, 23 Apr 2021 15:29:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 691F06B006E; Fri, 23 Apr 2021 15:29:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55C276B0070; Fri, 23 Apr 2021 15:29:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id 3C3FA6B0036 for ; Fri, 23 Apr 2021 15:29:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id EE881181C8F1F for ; Fri, 23 Apr 2021 19:29:43 +0000 (UTC) X-FDA: 78064621446.23.B1068F9 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf24.hostedemail.com (Postfix) with ESMTP id 43F0CA00038D for ; Fri, 23 Apr 2021 19:29:34 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id B7E7F61425; Fri, 23 Apr 2021 19:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1619206181; bh=hmXgOMfwOqJWu9RVsEL53nURi7NTe6eTVDA00J2JLGY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ghs6938sRT3RY96brYK9XC67wcNBnu5gflBqZKXhDOXIpujK/eN2ORs7mZ5d0cguv K/jbAImScii8I8CnZTmYjJPnnLMZOrLm5GK3V1w5q7qGV2ZtCEJQA6iL9AasAKxH0R VE0qhRHkPJIoxR4VbrvpEWBDikog8gNYrPI8DCiY= Date: Fri, 23 Apr 2021 12:29:40 -0700 From: Andrew Morton To: Hugh Dickins Cc: Matthew Wilcox , William Kucharski , Christoph Hellwig , Jan Kara , Dave Chinner , Johannes Weiner , "Kirill A. Shutemov" , Yang Shi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 2/2] mm/filemap: fix mapping_seek_hole_data on THP & 32-bit Message-Id: <20210423122940.26829dc784a4b6546349dac5@linux-foundation.org> In-Reply-To: References: <20210422011631.GL3596236@casper.infradead.org> <20210422160410.e9014b38b843d7a6ec06a9bb@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 43F0CA00038D X-Stat-Signature: 8pctc9z76wicdb6k3scd7gyc9tpw59p4 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619206174-262042 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 23 Apr 2021 10:22:51 -0700 (PDT) Hugh Dickins wrote: > On Thu, 22 Apr 2021, Andrew Morton wrote: > > On Thu, 22 Apr 2021 13:48:57 -0700 (PDT) Hugh Dickins wrote: > > > > > Andrew, I'd have just sent a -fix.patch to remove the unnecessary u64s, > > > but need to reword the commit message: so please replace yesterday's > > > mm-filemap-fix-mapping_seek_hole_data-on-thp-32-bit.patch > > > by this one - thanks. > > > > Actually, I routinely update the base patch's changelog when queueing a -fix. > > And thank you for that, but if there's time, I think we would still > prefer the final commit message to include corrections where Matthew > enlightened me (that "sign-extension" claim came from my confusion): That's my point. When I merge a -v2 as a -fix, I replace the v1 patch's changelog with v2's changelog so everything works out after folding.