From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16316C433ED for ; Thu, 22 Apr 2021 03:21:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3CDF361437 for ; Thu, 22 Apr 2021 03:21:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CDF361437 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7197B6B006C; Wed, 21 Apr 2021 23:21:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C9B36B006E; Wed, 21 Apr 2021 23:21:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 591796B0070; Wed, 21 Apr 2021 23:21:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 3BB3D6B006C for ; Wed, 21 Apr 2021 23:21:28 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E4DF96C17 for ; Thu, 22 Apr 2021 03:21:27 +0000 (UTC) X-FDA: 78058552614.27.FB9B1A4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id C67E940002D0 for ; Thu, 22 Apr 2021 03:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:Message-ID: Subject:To:From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=Pis/koNGfUSilCi9c4j/EPd8Vdh4HXizXmi3IG9jqsA=; b=coD7V8VpadUZ1WoZ9O5G46fBgM vQvZVCAfo/WaUJa8RxRFQRYA509rXJtesl6z9iEXDySlDKbyJaJph2T4mLpf5AtorPDbqEM31Ze7M sbyLjkVCr88+MKs96OU+IjNYuRNznjZRaAcmNOp7vhrLYpKGolU0DPbonpYI7MRTTqAxkdWpZr9CH d01XcPve0ZlZIUeiQ89ZwzV7h6NuiUd7pd+DXpK0eNVkTGWnvTagt4HgkmsnGzyyFiygW2SkG8c9r M5DNV3/siufjJckZdXEIbtanFNJAxErJYm2PNRVrjcrO+YiP+ZDWIWHcn2yQnuhHufKVPJziP0G8c /KQY5Ekw==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lZPtb-00HN68-RM; Thu, 22 Apr 2021 03:20:59 +0000 Date: Thu, 22 Apr 2021 04:20:51 +0100 From: Matthew Wilcox To: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: (in)consistency of page/folio function naming Message-ID: <20210422032051.GM3596236@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C67E940002D0 X-Stat-Signature: t66k9c8b6sjsxzhyqzhjgnkjpma4dk4y Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619061680-572010 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000061, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I'm going through my patch queue implementing peterz's request to rename FolioUptodate() as folio_uptodate(). It's going pretty well, but it throws into relief all the places where we're not consistent naming existing functions which operate on pages as page_foo(). The folio conversion is a great opportunity to sort that out. Mostly so far, I've just done s/page/folio/ on function names, but there's the opportunity to regularise a lot of them, eg: put_page folio_put lock_page folio_lock lock_page_or_retry folio_lock_or_retry rotate_reclaimable_page folio_rotate_reclaimable end_page_writeback folio_end_writeback clear_page_dirty_for_io folio_clear_dirty_for_io Some of these make a lot of sense -- eg when ClearPageDirty has turned into folio_clear_dirty(), having folio_clear_dirty_for_io() looks regular. I'm not entirely convinced about folio_lock(), but folio_lock_or_retry() makes more sense than lock_page_or_retry(). Ditto _killable() or _async(). Thoughts?