From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 087C4C433ED for ; Thu, 22 Apr 2021 00:08:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6DB2C6143B for ; Thu, 22 Apr 2021 00:08:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DB2C6143B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C859C6B006C; Wed, 21 Apr 2021 20:08:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C36E46B006E; Wed, 21 Apr 2021 20:08:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE65F6B0070; Wed, 21 Apr 2021 20:08:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 901AE6B006C for ; Wed, 21 Apr 2021 20:08:23 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 48FDA9991 for ; Thu, 22 Apr 2021 00:08:23 +0000 (UTC) X-FDA: 78058066086.06.3CCD7E2 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP id AB7FCC0007D5 for ; Thu, 22 Apr 2021 00:08:25 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9A85C6143B; Thu, 22 Apr 2021 00:08:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1619050101; bh=L1t4B1B1pfxXJyKmHsOx6DqicGkqYHHZS7hhDMBpdDo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=c0HKWMgE2qbvcdREn4T6zpUEAONCfHjsplBaQHjUjZ4F71X6HLSIt/EgtEwxY2Sqt pAClFlLq+vo8+dy33D9ZfCuDE5raEOkz+ez+f2mUQScRS88oj6wWgkMb46Dxfjk+Xb UIT695uZYLpV1Z+5gznOiCwFjoDRurX9AwuiaWnc= Date: Wed, 21 Apr 2021 17:08:21 -0700 From: Andrew Morton To: kernel test robot Cc: Alistair Popple , kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 14157/14231] kernel/resource.c:505:5: warning: no previous prototype for '__region_intersects' Message-Id: <20210421170821.04fc2844ea52018615e2e28a@linux-foundation.org> In-Reply-To: <202104220547.FqRxekCe-lkp@intel.com> References: <202104220547.FqRxekCe-lkp@intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AB7FCC0007D5 X-Stat-Signature: r3o4wem57q359m7g1s7wjz49k3pdufsj X-Rspamd-Server: rspam02 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619050105-685813 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 22 Apr 2021 05:33:54 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: b74523885a715463203d4ccc3cf8c85952d3701a > commit: edede6a2ecfe8553e8232eb863a7a13ef40da3a2 [14157/14231] kernel/resource: allow region_intersects users to hold resource_lock > config: mips-randconfig-r016-20210421 (attached as .config) > compiler: mips64el-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=edede6a2ecfe8553e8232eb863a7a13ef40da3a2 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout edede6a2ecfe8553e8232eb863a7a13ef40da3a2 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=mips > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > >> kernel/resource.c:505:5: warning: no previous prototype for '__region_intersects' [-Wmissing-prototypes] > 505 | int __region_intersects(resource_size_t start, size_t size, unsigned long flags, > | ^~~~~~~~~~~~~~~~~~~ > Thanks, I made __region_intersects() static. --- a/kernel/resource.c~kernel-resource-allow-region_intersects-users-to-hold-resource_lock-fix +++ a/kernel/resource.c @@ -502,8 +502,8 @@ int __weak page_is_ram(unsigned long pfn } EXPORT_SYMBOL_GPL(page_is_ram); -int __region_intersects(resource_size_t start, size_t size, unsigned long flags, - unsigned long desc) +static int __region_intersects(resource_size_t start, size_t size, + unsigned long flags, unsigned long desc) { struct resource res; int type = 0; int other = 0; _