From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08F92C43460 for ; Mon, 19 Apr 2021 09:42:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 819C061073 for ; Mon, 19 Apr 2021 09:41:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 819C061073 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1D2C76B006E; Mon, 19 Apr 2021 05:41:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1823C6B0070; Mon, 19 Apr 2021 05:41:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 024D06B0071; Mon, 19 Apr 2021 05:41:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id D71306B006E for ; Mon, 19 Apr 2021 05:41:58 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 825838249980 for ; Mon, 19 Apr 2021 09:41:58 +0000 (UTC) X-FDA: 78048625116.13.4109884 Received: from r3-21.sinamail.sina.com.cn (r3-21.sinamail.sina.com.cn [202.108.3.21]) by imf01.hostedemail.com (Postfix) with SMTP id 3F9A05001530 for ; Mon, 19 Apr 2021 09:40:55 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([221.199.207.228]) by sina.com (172.16.97.32) with ESMTP id 607D50250002C0A8; Mon, 19 Apr 2021 17:40:55 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 355996628851 From: Hillf Danton To: Marco Elver Cc: akpm@linux-foundation.org, glider@google.com, dvyukov@google.com, jannh@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com Subject: Re: [PATCH 1/3] kfence: await for allocation using wait_event Date: Mon, 19 Apr 2021 17:40:44 +0800 Message-Id: <20210419094044.311-1-hdanton@sina.com> In-Reply-To: <20210419085027.761150-2-elver@google.com> References: <20210419085027.761150-1-elver@google.com> MIME-Version: 1.0 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3F9A05001530 X-Stat-Signature: zaz63nmi3ayffrq6t48q5ghan4wpewmb Received-SPF: none (sina.com>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=r3-21.sinamail.sina.com.cn; client-ip=202.108.3.21 X-HE-DKIM-Result: none/none X-HE-Tag: 1618825255-519772 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000594, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 19 Apr 2021 10:50:25 Marco Elver wrote: > + > + WRITE_ONCE(kfence_timer_waiting, true); > + smp_mb(); /* See comment in __kfence_alloc(). */ This is not needed given task state change in wait_event(). > + wait_event_timeout(allocation_wait, atomic_read(&kfence_allocation_ga= te), HZ); > + smp_store_release(&kfence_timer_waiting, false); /* Order after wait_= event(). */ > +