From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C099C433B4 for ; Fri, 16 Apr 2021 05:16:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE0AE610FB for ; Fri, 16 Apr 2021 05:16:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE0AE610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8DBF86B0083; Fri, 16 Apr 2021 01:16:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 887316B0085; Fri, 16 Apr 2021 01:16:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 729D56B0087; Fri, 16 Apr 2021 01:16:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 557426B0083 for ; Fri, 16 Apr 2021 01:16:20 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1CE58182371CB for ; Fri, 16 Apr 2021 05:16:20 +0000 (UTC) X-FDA: 78037069320.28.67EC0AD Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf20.hostedemail.com (Postfix) with ESMTP id 4B05212E for ; Fri, 16 Apr 2021 05:16:14 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id q14-20020a17090a430eb02901503aaee02bso2898255pjg.3 for ; Thu, 15 Apr 2021 22:16:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uQtbD7P4vc1vn6sj+rqk5iopinYS+ejCLWKURjwvog0=; b=mRtbHxsAw7+QrX8ggNXOLMpdmdVUi7Qf1Lpa81SHEUBjmwEClOHj/sH4gvAYCq8zPZ xWibDLFCrAzBmZDv70d88yqFQse8c9LDa2GH++SJosfSXH710S1MN91bD9nh5dZhoJ+Z k0lLVEqXe3+hW7vEtcqBkSlhNOw9VTcVBej93UknAw8Nnf+qblXwim/FTZBj8ayS/sT2 9NOkyYaLvrpYcu5oKbIJ7zcZJgeAmkEZyf5w8lja3um9r8ULyUkEgRgQ0hnfg7qKs0Eq F5EShwqc6drtDgM19zTdg9A10CWl1boL9f0t+t3Bg3N9uDCy5PRtVitu16kREDAQyi/E XbHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uQtbD7P4vc1vn6sj+rqk5iopinYS+ejCLWKURjwvog0=; b=g8JestJM82slUovQOSURexwQiB3Gvd83s9Z7mV8vNaP4SS5F5E9Pws09ORGVzBpxyZ T7yPL7XxwIaU0wBPRSNG6qjuXeB+ugH4kxFq0TCdWGjnaFYZuaGOLaalICP3dLfhYT06 drXDrvomzUEDx4hZHp7d+AthBnpamYFjWf9YT6YhCLXJJTL2aqw2xbHvMyO0cOPkspiC g7qNCv6hZHmxgEgmQC03ofiVDUS4mJwISu9llKVp6Za3qpCm9zOg0iF9FwzCtPO4SfQS 31aUaZIJkfiZKuBFRaUawO+OGZr4KvLD4H2N507NIDd8sgWh+590Mase9AuJyFHe4Dpg +O2w== X-Gm-Message-State: AOAM532MMnpjcjoajk7AH9qLFbxooj2tWRrwF1fpCHdUqMktMMnH9sEa saOXaznI2PyCK9ig1jAa66nzLQ== X-Google-Smtp-Source: ABdhPJzsgKapGnuNFn0l7TP15/XU9x0NbvQ/D9jy8GoSu4oybHVT5scnv3+3n7GIFQav84toXIR3Nw== X-Received: by 2002:a17:902:c948:b029:e9:8f01:fa8e with SMTP id i8-20020a170902c948b02900e98f01fa8emr7765675pla.37.1618550179022; Thu, 15 Apr 2021 22:16:19 -0700 (PDT) Received: from localhost.localdomain ([139.177.225.235]) by smtp.gmail.com with ESMTPSA id j7sm3518540pfd.129.2021.04.15.22.16.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Apr 2021 22:16:18 -0700 (PDT) From: Muchun Song To: guro@fb.com, hannes@cmpxchg.org, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, Muchun Song , Michal Hocko Subject: [PATCH v2 8/8] mm: vmscan: remove noinline_for_stack Date: Fri, 16 Apr 2021 13:14:07 +0800 Message-Id: <20210416051407.54878-9-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20210416051407.54878-1-songmuchun@bytedance.com> References: <20210416051407.54878-1-songmuchun@bytedance.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4B05212E X-Stat-Signature: 7ggsj9b3kbxhczmohqk4ahy8i3jss49s Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mail-pj1-f46.google.com; client-ip=209.85.216.46 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618550174-536778 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: set up pagevec as late as possible in shrink_inactive_list()"), its purpose is to delay the allocation of pagevec as late as possible to save stack memory. But the commit 2bcf88796381 ("mm: take pagevecs off reclaim stack") replace pagevecs by lists of pages_to_free. So we do not need noinline_for_stack, just remove it (let the compiler decide whether to inline). Signed-off-by: Muchun Song Acked-by: Johannes Weiner Acked-by: Roman Gushchin Reviewed-by: Shakeel Butt Acked-by: Michal Hocko --- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 2bc5cf409958..2d2727b78df9 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2014,8 +2014,8 @@ static int too_many_isolated(struct pglist_data *pg= dat, int file, * * Returns the number of pages moved to the given lruvec. */ -static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruv= ec, - struct list_head *list) +static unsigned int move_pages_to_lru(struct lruvec *lruvec, + struct list_head *list) { int nr_pages, nr_moved =3D 0; LIST_HEAD(pages_to_free); @@ -2095,7 +2095,7 @@ static int current_may_throttle(void) * shrink_inactive_list() is a helper for shrink_node(). It returns the= number * of reclaimed pages */ -static noinline_for_stack unsigned long +static unsigned long shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec, struct scan_control *sc, enum lru_list lru) { --=20 2.11.0