From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 592CFC433B4 for ; Thu, 15 Apr 2021 03:00:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BC1BC611AB for ; Thu, 15 Apr 2021 03:00:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC1BC611AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CE21C6B0036; Wed, 14 Apr 2021 23:00:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C923D6B006C; Wed, 14 Apr 2021 23:00:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B32C56B0070; Wed, 14 Apr 2021 23:00:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 9763A6B0036 for ; Wed, 14 Apr 2021 23:00:08 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 405585DEA for ; Thu, 15 Apr 2021 03:00:08 +0000 (UTC) X-FDA: 78033097296.27.740F220 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by imf26.hostedemail.com (Postfix) with ESMTP id A255040002D9 for ; Thu, 15 Apr 2021 03:00:02 +0000 (UTC) IronPort-SDR: 9UlGX3kkcRPWs9vMw6ifJsZRlA7BrtnhM/YUgLw3uPNCHlV8zvjrhBsrYQHwlE74rVyKfefGGI W90PduWAsYyw== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="256098229" X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="256098229" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 20:00:04 -0700 IronPort-SDR: VDz1WHuoJmQSOw4QAGB6X8hLCkkLQJGQd3VurnT3a/J+RdYXIF1KkofUN6tXc73hcsJsHaaDG5 mJfy3t8ztxew== X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="444035292" Received: from tassilo.jf.intel.com ([10.54.74.11]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 20:00:04 -0700 Date: Wed, 14 Apr 2021 20:00:02 -0700 From: Andi Kleen To: Yu Zhao Cc: Rik van Riel , Dave Chinner , Jens Axboe , SeongJae Park , Linux-MM , Andrew Morton , Benjamin Manes , Dave Hansen , Hillf Danton , Johannes Weiner , Jonathan Corbet , Joonsoo Kim , Matthew Wilcox , Mel Gorman , Miaohe Lin , Michael Larabel , Michal Hocko , Michel Lespinasse , Roman Gushchin , Rong Chen , SeongJae Park , Tim Chen , Vlastimil Babka , Yang Shi , Ying Huang , Zi Yan , linux-kernel , lkp@lists.01.org, Kernel Page Reclaim v2 Subject: Re: [PATCH v2 00/16] Multigenerational LRU Framework Message-ID: <20210415030002.GX3762101@tassilo.jf.intel.com> References: <20210413075155.32652-1-sjpark@amazon.de> <3ddd4f8a-8e51-662b-df11-a63a0e75b2bc@kernel.dk> <20210413231436.GF63242@dread.disaster.area> <20210414155130.GU3762101@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A255040002D9 X-Stat-Signature: 6ck6exyeot5squmy6tyycwdg7hgmfhhe Received-SPF: none (linux.intel.com>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mga06.intel.com; client-ip=134.134.136.31 X-HE-DKIM-Result: none/none X-HE-Tag: 1618455602-461773 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > We fall back to the rmap when it's obviously not smart to do so. There > is still a lot of room for improvement in this function though, i.e., > it should be per VMA and NUMA aware. Okay so it's more a question to tune the cross over heuristic. That sounds much easier than replacing everything. Of course long term it might be a problem to maintain too many different ways to do things, but I suppose short term it's a reasonable strategy. -Andi