From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A37C433B4 for ; Tue, 13 Apr 2021 06:58:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 19792613AE for ; Tue, 13 Apr 2021 06:58:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19792613AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A9F366B009C; Tue, 13 Apr 2021 02:58:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A75656B009E; Tue, 13 Apr 2021 02:58:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93F296B009F; Tue, 13 Apr 2021 02:58:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 78C936B009C for ; Tue, 13 Apr 2021 02:58:07 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3AFF08792 for ; Tue, 13 Apr 2021 06:58:07 +0000 (UTC) X-FDA: 78026439414.02.B007AA6 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf20.hostedemail.com (Postfix) with ESMTP id 6E36513A for ; Tue, 13 Apr 2021 06:58:02 +0000 (UTC) Received: by mail-pg1-f182.google.com with SMTP id q10so11247935pgj.2 for ; Mon, 12 Apr 2021 23:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bdhaQ5mP8Ps2L1OS7f25L6onCgsPCveY4DfI6OcUTcA=; b=zGHAEn5+HYX5vVZwfFXCcJNdGf6EJdpTl1UmeK5gSzvLt16cZ4/g1Qs53J0H0mtrdt HumqY6jWtfForTqeYwAAPCzyywtO+c+A0kEohE6BZCcpzejZt36TkbLlfj4xitbnfGRR zv7DhDVV53ex62qdLzmAjz7sb41qMJ+awZfmCAK636xBgZYJF3Hr7ykdOMkgmyGJRKiu 3Uj7ti3Sc9tyU5RYMveeV0ABz+EJwCc73UZZdLVXdjAUiLI70A37vdWl7UIY5HITqh+7 4cpZ1lJmVsms91ZQAn0kiELwhnBQuSH3ZEl2c3RibhgZsjAsWIAk2ObGXXCT2x19KRZU MOOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bdhaQ5mP8Ps2L1OS7f25L6onCgsPCveY4DfI6OcUTcA=; b=etMCv3K7HfbH8cl0O2GfYZB1zwAmlk6Uji10QUjxlJgG3rmHuRRRGKQX9UfeQ4ab6f efvj2A5d0s+iDc1p3SPsaVCJYkmHDpQ3AMbDZ9VHf+K84ABtWGiM/5jhYvaod4oT8TSr BzWW15+scVyjFII/ac+VtdWOd27arNQ4KJLOjU6RPmgwdnj6WED06fzm2NA5w0frR7GQ XXHUoqDg599vG1UIcxxh0jRPRH/hyPaq5waHq/JcAnOSscIeIET8noEdHiss4/3ZeQHM /dTXt1KHN4egWTwD3mH8PMYTkyEC0Jc6qrlrZqcEi1DsIeYMmL+T7VAwqZpEMunyHHeL meww== X-Gm-Message-State: AOAM531us96yMyo/LfyemUGfec5X87M55FRS++sYNEHBsCHl9VIEum5o FCMdkUug/pIunHiJ1Lghm/6ajA== X-Google-Smtp-Source: ABdhPJxkqc0xpu3YaF1nM5me0VVuSkfci2Ug8vJGDZJJiMNgpqzmmeNsvLCbaDDCl7NfZxWPPWIj8w== X-Received: by 2002:a63:e707:: with SMTP id b7mr30425925pgi.389.1618297086205; Mon, 12 Apr 2021 23:58:06 -0700 (PDT) Received: from localhost.localdomain ([139.177.225.241]) by smtp.gmail.com with ESMTPSA id 78sm11508562pfu.40.2021.04.12.23.58.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Apr 2021 23:58:05 -0700 (PDT) From: Muchun Song To: guro@fb.com, hannes@cmpxchg.org, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, fam.zheng@bytedance.com, Muchun Song Subject: [PATCH 7/7] mm: vmscan: remove noinline_for_stack Date: Tue, 13 Apr 2021 14:51:53 +0800 Message-Id: <20210413065153.63431-8-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20210413065153.63431-1-songmuchun@bytedance.com> References: <20210413065153.63431-1-songmuchun@bytedance.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 6E36513A X-Stat-Signature: 3nf14hg7udq8yunh89g1jnodxjg4yp8w X-Rspamd-Server: rspam02 Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mail-pg1-f182.google.com; client-ip=209.85.215.182 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618297082-739763 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: set up pagevec as late as possible in shrink_inactive_list()"), its purpose is to delay the allocation of pagevec as late as possible to save stack memory. But the commit 2bcf88796381 ("mm: take pagevecs off reclaim stack") replace pagevecs by lists of pages_to_free. So we do not need noinline_for_stack, just remove it (let the compiler decide whether to inline). Signed-off-by: Muchun Song Acked-by: Johannes Weiner Acked-by: Roman Gushchin Reviewed-by: Shakeel Butt --- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 64bf07cc20f2..e40b21298d77 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2015,8 +2015,8 @@ static int too_many_isolated(struct pglist_data *pg= dat, int file, * * Returns the number of pages moved to the given lruvec. */ -static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruv= ec, - struct list_head *list) +static unsigned int move_pages_to_lru(struct lruvec *lruvec, + struct list_head *list) { int nr_pages, nr_moved =3D 0; LIST_HEAD(pages_to_free); @@ -2096,7 +2096,7 @@ static int current_may_throttle(void) * shrink_inactive_list() is a helper for shrink_node(). It returns the= number * of reclaimed pages */ -static noinline_for_stack unsigned long +static unsigned long shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec, struct scan_control *sc, enum lru_list lru) { --=20 2.11.0