From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30125C43461 for ; Mon, 12 Apr 2021 23:47:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C04366128A for ; Mon, 12 Apr 2021 23:47:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C04366128A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 35AD46B0036; Mon, 12 Apr 2021 19:47:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30AA06B006E; Mon, 12 Apr 2021 19:47:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 136FD6B0070; Mon, 12 Apr 2021 19:47:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id E74436B0036 for ; Mon, 12 Apr 2021 19:47:15 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A6B3D3641 for ; Mon, 12 Apr 2021 23:47:15 +0000 (UTC) X-FDA: 78025353630.11.4AAE9D0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf14.hostedemail.com (Postfix) with ESMTP id C20F7C0007C1 for ; Mon, 12 Apr 2021 23:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618271234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wOlYJ8gOWVcLmeEYE6eSkfjpllqClsrslpwu4Ap6W2U=; b=bHom31ebEqfmqM5zkPx1MAN8leARD+8pWSJRi1Ng2tS24P1m6Q5p/Cg10pSkL8tqZ/vEVO b2075k4i5mNkocrM7oYKGk4AO9BePa8meqlOxTitERCWZQMqxUPuTNg8Hsq0Bo97QrbiiJ neZaqQEmj1GqDLCRqi9aVuiouqBEfiM= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-7-GVmDzdMvq8udyb1E-_Cw-1; Mon, 12 Apr 2021 19:47:12 -0400 X-MC-Unique: 7-GVmDzdMvq8udyb1E-_Cw-1 Received: by mail-qk1-f197.google.com with SMTP id n191so9525456qka.9 for ; Mon, 12 Apr 2021 16:47:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wOlYJ8gOWVcLmeEYE6eSkfjpllqClsrslpwu4Ap6W2U=; b=pq1hjF6QHzXpxef+yrbRC2QqK+prc2nZCm/KZ2YYBrSutx56aQV6uIOmRz0NGbbOFr xt6JZEwNmCPymciiyX+es3aXBrdKOOhz8gVnzkUtCL20ZjYAVdrBmCvJkGkE20AaYL6T ERiBYYZsLoodadW96ejxE0UYjbDyXvI6aUJfXL2Qep1JWeJX1KoG4PqoUWDiBhlXkzky NjVErF/LKdG12JotTords9QCBrjmhR9vX+WQXg3u9oLk8TEP4WjDeHIMsqQgFkai4Axm xSxBkyKo7zc5MbaNE6xPQLT76STh5sPWCgEQeB8wfQkgJ7+ayTR0U6RnAeUlvCcae/j5 ssFw== X-Gm-Message-State: AOAM533sxLwnqnRmKeTImCqS75wokkyJBGXZglnT6smaUiZhmK+wSSNG KqrSs8ezS4JalRj0OMokxDKJ2erxAWk+KMAx/d3OOxkAXgxAEkkhOU0wTbhYNQuqZ5k91suDk/b 071KIF3Z1PKY= X-Received: by 2002:ac8:7eeb:: with SMTP id r11mr27318625qtc.386.1618271232161; Mon, 12 Apr 2021 16:47:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwt11l4Cmqc8ipKHVN8+7B3+t8Kvpj6xeiTM99PZLhifufYZQq8uWPSWVpgHfhlat2939djGg== X-Received: by 2002:ac8:7eeb:: with SMTP id r11mr27318609qtc.386.1618271231937; Mon, 12 Apr 2021 16:47:11 -0700 (PDT) Received: from xz-x1 (bras-base-toroon474qw-grc-88-174-93-75-154.dsl.bell.ca. [174.93.75.154]) by smtp.gmail.com with ESMTPSA id b83sm3341647qkc.97.2021.04.12.16.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 16:47:11 -0700 (PDT) Date: Mon, 12 Apr 2021 19:47:07 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrea Arcangeli , Andrew Morton , Daniel Colascione , Hugh Dickins , Jerome Glisse , Joe Perches , Lokesh Gidra , Mike Kravetz , Mike Rapoport , Shaohua Li , Shuah Khan , Stephen Rothwell , Wang Qing , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Brian Geffon , "Dr . David Alan Gilbert" , Mina Almasry , Oliver Upton Subject: Re: [PATCH 1/9] userfaultfd/hugetlbfs: avoid including userfaultfd_k.h in hugetlb.h Message-ID: <20210412234707.GB1002612@xz-x1> References: <20210408234327.624367-1-axelrasmussen@google.com> <20210408234327.624367-2-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20210408234327.624367-2-axelrasmussen@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C20F7C0007C1 X-Stat-Signature: mhk5jn7ngxhnmw5zzj5ij4ptk8thk1go Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618271227-427784 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 08, 2021 at 04:43:19PM -0700, Axel Rasmussen wrote: > Minimizing header file inclusion is desirable. In this case, we can do > so just by forward declaring the enumeration our signature relies upon. > > Signed-off-by: Axel Rasmussen > --- > include/linux/hugetlb.h | 5 ++++- > mm/hugetlb.c | 1 + > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 1d3246b31a41..dfb749eaf348 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -11,7 +11,6 @@ > #include > #include > #include > -#include > > struct ctl_table; > struct user_struct; > @@ -136,6 +135,8 @@ unsigned long hugetlb_total_pages(void); > vm_fault_t hugetlb_fault(struct mm_struct *mm, struct vm_area_struct *vma, > unsigned long address, unsigned int flags); > #ifdef CONFIG_USERFAULTFD > +enum mcopy_atomic_mode; (I'm not 100% sure, but.. maybe this can be moved even out of ifdef? Then you can define it once at the top rather than twice?) Reviewed-by: Peter Xu -- Peter Xu