From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67238C43460 for ; Fri, 9 Apr 2021 11:18:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CDEB6611ED for ; Fri, 9 Apr 2021 11:17:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDEB6611ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2A55C6B006C; Fri, 9 Apr 2021 07:17:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 242556B006E; Fri, 9 Apr 2021 07:17:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E3DF6B0070; Fri, 9 Apr 2021 07:17:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id E57BF6B006C for ; Fri, 9 Apr 2021 07:17:58 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9A6A11730842 for ; Fri, 9 Apr 2021 11:17:58 +0000 (UTC) X-FDA: 78012579036.33.5F29B1E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id EE326200025C for ; Fri, 9 Apr 2021 11:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0G+omcGOetSmBATjuAzTrvUrz2CKNcOMwN8ZffcfyG4=; b=cYjFYTUAND/8orFcuvXNhJh1Pn S4JLFssq7lsdlXEYLFeO7iCpsoeEuDQZRQus+40z4ZiKzZfGqh0Txij8C4sO4nivhKozSMZhzMR67 58doyVPxBZtBqonPz5HD8++G2Cye3xFp0YwjxhN8HrqnnfLaMDS2T8rKFmYuOKyUCVkn4nNME1OmP R2+kdWozmWuuf2wa7o17y1AGWbUvm7Q8EWqa2dcT0Y/l/fcCge0kMN4Eo++bIdeHCZVpLcrL1x7Bb 1VY6fdzgy2VnC9oQnRyfbtE1k/K+zbBQSRPWyC67EMnX5Qef2wHj1w+vHR7UlrOZksh+r/yu4rBEy 9kcK7F2w==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lUp7s-000GjE-Mr; Fri, 09 Apr 2021 11:17:01 +0000 Date: Fri, 9 Apr 2021 12:16:36 +0100 From: Matthew Wilcox To: David Howells Cc: torvalds@linux-foundation.org, Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, jlayton@kernel.org, hch@lst.de, linux-cachefs@redhat.com, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/3] mm: Return bool from pagebit test functions Message-ID: <20210409111636.GR2531743@casper.infradead.org> References: <161796595714.350846.1547688999823745763.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <161796595714.350846.1547688999823745763.stgit@warthog.procyon.org.uk> X-Stat-Signature: i4j67utc851p5u9wz9fz9bb8no3fy177 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EE326200025C Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617967071-459999 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 09, 2021 at 11:59:17AM +0100, David Howells wrote: > Make functions that test page bits return a bool, not an int. This means > that the value is definitely 0 or 1 if they're used in arithmetic, rather > than rely on test_bit() and friends to return this (though they probably > should). iirc i looked at doing this as part of the folio work, and it ended up increasing the size of the kernel. Did you run bloat-o-meter on the result of doing this?