From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3445CC433B4 for ; Tue, 6 Apr 2021 10:05:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9030D613C9 for ; Tue, 6 Apr 2021 10:05:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9030D613C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2A4E96B007E; Tue, 6 Apr 2021 06:05:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2567F6B0080; Tue, 6 Apr 2021 06:05:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F64E6B0081; Tue, 6 Apr 2021 06:05:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id EBD666B007E for ; Tue, 6 Apr 2021 06:05:09 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 88CDC180ACF8B for ; Tue, 6 Apr 2021 10:05:09 +0000 (UTC) X-FDA: 78001509138.25.9FA2445 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf07.hostedemail.com (Postfix) with ESMTP id EE6CFA0003A4 for ; Tue, 6 Apr 2021 10:05:08 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id 12so21657720lfq.13 for ; Tue, 06 Apr 2021 03:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LCL0Idnlb7guUbYyS2ZyKusS1ukOTUVL+jvswqtN1Wg=; b=aaikD3f927e+oV/TE/U42Sxn70A9IdaWcEDOH2UrA76DQZoQPFvEjH/LG9So/U+dQt 2ExzQjhEsYqE99acWYGpQTUTXkxigCQijGv5D77HF6DCAd/sfsEt2Kt9fyISL2HKBToX NkYpj8lUJY9SUvWEyEe3QGIHukNJCUGbRnri3YgwzwQlcCXZEIgoG96wv5/c6HCkL4KD GdFlHUFHZCIbC/vPzRJsGD+k3cB0eXTs/xyruP5cZ2GsZWxS/RtpFWlsda4jtkim4+Wv PIC0Z/9TjX1dZDqfbb6MLwk1TVEbVMlwoGCffKWQfMAF23k+cPEaET1dUSFMcejOouvz fXzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LCL0Idnlb7guUbYyS2ZyKusS1ukOTUVL+jvswqtN1Wg=; b=LyKJ4wO6rQ7hESI3jb/2AN8gdCWbFQwIiV3g3agqNK9z0vNBixMusRtjcYpn87nQep FWD2lQ6+RRXDQbHuc75pvCejEsM+S3trVRUlFnVDi03qpp/6cXsZjL57ILff12Ee9P6Z jx6dxiflLlHC6NyxrjL+wJdMAbnFEUcysH45ohyJWS56KVaWs9GmY4StadSeiiWc0qLT oyua+fX6FVJedIAlx32B3R7wxioKMAkWZvLS5BbsVdsE025sW5/smPVZmw7qeWo6iyWW tqmUk3AQXqwzGdtZFDcQZ99ZZw1lkPio0Ey9OVEvQcSwUAGQD8cwuALgHs0AbZXxNm// Zt0w== X-Gm-Message-State: AOAM533B7qqlQl4DzrD/l1gXbO6I1c0hfJCXb6Ya8t8t/X5Ef1ip4r9L 8ZTAZgBOSikrkx32RkeOyUs= X-Google-Smtp-Source: ABdhPJxPPdZcMkC3i2xXr1wTU6pvbxIQa35/4FyLUpTTXusaeWJI5o5fphhP99qp8jsXBkRALamK4A== X-Received: by 2002:a05:6512:3087:: with SMTP id z7mr134699lfd.224.1617703507565; Tue, 06 Apr 2021 03:05:07 -0700 (PDT) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id y11sm2211287ljc.18.2021.04.06.03.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 03:05:06 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 6 Apr 2021 12:05:05 +0200 To: Andrew Morton Cc: Uladzislau Rezki , linux-mm@kvack.org, LKML , Hillf Danton , Michal Hocko , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH-next 2/5] lib/test_vmalloc.c: add a new 'nr_threads' parameter Message-ID: <20210406100505.GA1880@pc638.lan> References: <20210402202237.20334-1-urezki@gmail.com> <20210402202237.20334-2-urezki@gmail.com> <20210402145934.719192be298eadbeecb321d2@linux-foundation.org> <20210403123143.GA38147@pc638.lan> <20210405193920.46d3792200ad05f4a7c66829@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210405193920.46d3792200ad05f4a7c66829@linux-foundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EE6CFA0003A4 X-Stat-Signature: yssiq1yfujq7gh365amaaorb8kzd5fai Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=mail-lf1-f45.google.com; client-ip=209.85.167.45 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617703508-146628 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 05, 2021 at 07:39:20PM -0700, Andrew Morton wrote: > On Sat, 3 Apr 2021 14:31:43 +0200 Uladzislau Rezki wrote: > > > > > > > We may need to replaced that kcalloc() with kmvalloc() though... > > > > > Yep. If we limit to USHRT_MAX, the maximum amount of memory for > > internal data would be ~12MB. Something like below: > > > > diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c > > index d337985e4c5e..a5103e3461bf 100644 > > --- a/lib/test_vmalloc.c > > +++ b/lib/test_vmalloc.c > > @@ -24,7 +24,7 @@ > > MODULE_PARM_DESC(name, msg) \ > > > > __param(int, nr_threads, 0, > > - "Number of workers to perform tests(min: 1 max: 1024)"); > > + "Number of workers to perform tests(min: 1 max: 65536)"); > > > > __param(bool, sequential_test_order, false, > > "Use sequential stress tests order"); > > @@ -469,13 +469,13 @@ init_test_configurtion(void) > > { > > /* > > * A maximum number of workers is defined as hard-coded > > - * value and set to 1024. We add such gap just in case > > + * value and set to 65536. We add such gap just in case > > * and for potential heavy stressing. > > */ > > - nr_threads = clamp(nr_threads, 1, 1024); > > + nr_threads = clamp(nr_threads, 1, 65536); > > > > /* Allocate the space for test instances. */ > > - tdriver = kcalloc(nr_threads, sizeof(*tdriver), GFP_KERNEL); > > + tdriver = kvcalloc(nr_threads, sizeof(*tdriver), GFP_KERNEL); > > if (tdriver == NULL) > > return -1; > > > > @@ -555,7 +555,7 @@ static void do_concurrent_test(void) > > i, t->stop - t->start); > > } > > > > - kfree(tdriver); > > + kvfree(tdriver); > > } > > > > static int vmalloc_test_init(void) > > > > Does it sound reasonable for you? > > I think so. It's a test thing so let's give testers more flexibility, > remembering that they don't need as much protection from their own > mistakes. > OK. I will send one more extra patch then. -- Vlad Rezki