From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8572C433ED for ; Tue, 6 Apr 2021 00:52:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5F23F613EF for ; Tue, 6 Apr 2021 00:52:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F23F613EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B08A66B007B; Mon, 5 Apr 2021 20:52:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB8F86B007D; Mon, 5 Apr 2021 20:52:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95ACB6B007E; Mon, 5 Apr 2021 20:52:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id 75F2F6B007B for ; Mon, 5 Apr 2021 20:52:50 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3AB1E180255A9 for ; Tue, 6 Apr 2021 00:52:50 +0000 (UTC) X-FDA: 78000117300.36.978ACA5 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf07.hostedemail.com (Postfix) with ESMTP id D1CF3A000382 for ; Tue, 6 Apr 2021 00:52:48 +0000 (UTC) IronPort-SDR: V5y2p5X4Xy1NPvCmEnIXqTUFBsLEuFCstI7OnAr0tRRUmxLfZbCRor9xJGqymNfRGf64teQDDT 2tKOckH0zPwQ== X-IronPort-AV: E=McAfee;i="6000,8403,9945"; a="193066435" X-IronPort-AV: E=Sophos;i="5.81,308,1610438400"; d="scan'208";a="193066435" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2021 17:52:46 -0700 IronPort-SDR: FpwVQIWh8V+WiAx3M9WdlTweYtsUUPvLAK2XmT8wUbVhKmixHsvTCmwqFh8UkVyumTElDCua6q /BiXdk8YB59w== X-IronPort-AV: E=Sophos;i="5.81,308,1610438400"; d="scan'208";a="414520874" Received: from shao2-debian.sh.intel.com (HELO localhost) ([10.239.13.11]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2021 17:52:45 -0700 Date: Tue, 6 Apr 2021 08:51:51 +0800 From: kernel test robot To: Gwan-gyeong Mun Cc: kbuild-all@lists.01.org, Linux Memory Management List , =?utf-8?B?Sm9zw6k=?= Roberto de Souza , Anshuman Gupta Subject: [linux-next:master 317/9190] drivers/gpu/drm/i915/display/intel_psr.c:1517:30: warning: Redundant condition: intel_dp->psr.enabled. '!A || (A && B)' is equivalent to '!A || B' [redundantCondition] Message-ID: <20210406005151.GD176778@shao2-debian> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D1CF3A000382 X-Stat-Signature: 3utu6uj7ct9p854oen56zj55pi7dppi8 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=mga09.intel.com; client-ip=134.134.136.24 X-HE-DKIM-Result: none/none X-HE-Tag: 1617670368-549544 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 454c576c3f5e51d60f00a4ac0dde07f4f9d70e9d commit: b64d6c51380b7dea17d5503a250ca9cc84025453 [317/9190] drm/i915/display: Support PSR Multiple Instances compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> drivers/gpu/drm/i915/display/intel_psr.c:1517:30: warning: Redundant condition: intel_dp->psr.enabled. '!A || (A && B)' is equivalent to '!A || B' [redundantCondition] if (!intel_dp->psr.enabled || ^ drivers/gpu/drm/i915/display/intel_psr.c:362:11: warning: Same expression on both sides of '-'. [duplicateExpression] [3] = 1 - 1, ^ vim +1517 drivers/gpu/drm/i915/display/intel_psr.c c43dbcbbcc8c51 drivers/gpu/drm/i915/intel_psr.c Tarun Vyas 2018-06-27 1495 b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1496 /** b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1497 * intel_psr_wait_for_idle - wait for PSR1 to idle b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1498 * @new_crtc_state: new CRTC state b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1499 * b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1500 * This function is expected to be called from pipe_update_start() where it is b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1501 * not expected to race with PSR enable or disable. b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1502 */ b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1503 void intel_psr_wait_for_idle(const struct intel_crtc_state *new_crtc_state) b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1504 { b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1505 struct drm_i915_private *dev_priv = to_i915(new_crtc_state->uapi.crtc->dev); b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1506 struct intel_encoder *encoder; b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1507 b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1508 if (!new_crtc_state->has_psr) b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1509 return; b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1510 b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1511 for_each_intel_encoder_mask_can_psr(&dev_priv->drm, encoder, b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1512 new_crtc_state->uapi.encoder_mask) { b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1513 struct intel_dp *intel_dp = enc_to_intel_dp(encoder); b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1514 u32 psr_status; b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1515 b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1516 mutex_lock(&intel_dp->psr.lock); b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 @1517 if (!intel_dp->psr.enabled || b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1518 (intel_dp->psr.enabled && intel_dp->psr.psr2_enabled)) { b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1519 mutex_unlock(&intel_dp->psr.lock); b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1520 continue; b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1521 } b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1522 b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1523 /* when the PSR1 is enabled */ b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1524 if (psr_wait_for_idle(intel_dp, &psr_status)) b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1525 drm_err(&dev_priv->drm, b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1526 "PSR idle timed out 0x%x, atomic update may fail\n", b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1527 psr_status); b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1528 mutex_unlock(&intel_dp->psr.lock); b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1529 } b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1530 } b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 2021-02-04 1531 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org