From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3561FC433ED for ; Mon, 5 Apr 2021 18:19:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7B2B3613B1 for ; Mon, 5 Apr 2021 18:19:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B2B3613B1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 091686B006E; Mon, 5 Apr 2021 14:19:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03E1D6B0073; Mon, 5 Apr 2021 14:19:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E21B06B0075; Mon, 5 Apr 2021 14:19:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id C20E06B006E for ; Mon, 5 Apr 2021 14:19:14 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7B94410EFC for ; Mon, 5 Apr 2021 18:19:14 +0000 (UTC) X-FDA: 77999125428.14.AC1E048 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 7E12DE00010F for ; Mon, 5 Apr 2021 18:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4dAj4hbKO4o0Nvf/Cfrivun8zn0T3Dz0SUzA27d7JhI=; b=HXwRjnV7dgC5kgsmOPwpACzNbC DQTxl3HgSgxd29GQrJcqgV9D38jJ7IcR6m+N8EYGiKIhy4DkFCRJi3TAHZwERDMwHt+buH2FdDapX +nJZhV9Fl+N29OWPDI7cMtIeXKRNCo9oTkiP7jEjXV4mYN1wMSTYZWGYGC30cbP2/j3HWdDqAmnE2 SjfIzjvf3QN88o+W+gl2pncVH96ejZkSrVdYV8dEQgoOWqBhBuepZzRnIQdHYd9ydBZUqmzvUJKPu van7sTTbSJ4yY/sGcu6xRxr7dFdrz8+Qg1KLpyDQO4Uy08f04YXJvKkFH19ShxQ7KWTwNB75TlRIL +KDqLWHQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTToQ-00Bj7Y-Ar; Mon, 05 Apr 2021 18:19:01 +0000 Date: Mon, 5 Apr 2021 19:18:58 +0100 From: Matthew Wilcox To: Mike Rapoport Cc: Andrew Morton , Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: move page_rmapping() and page_anon_vma() to mm/internal.h Message-ID: <20210405181858.GJ2531743@casper.infradead.org> References: <20210405151355.9867-1-rppt@kernel.org> <20210405151355.9867-2-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210405151355.9867-2-rppt@kernel.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7E12DE00010F X-Stat-Signature: uyci8ef4hw1w8bm3tbey5wwexzusiddm Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf21; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617646752-71034 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 05, 2021 at 06:13:54PM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > The functions page_rmapping() and page_anon_vma() are not used outside core > mm. Move their declaration from include/linux/mm.h to mm/internal.h > > Signed-off-by: Mike Rapoport This has purely textual conflicts with the folio series, but no conceptual conflicts. I generally approve of moving things out of mm.h, so Reviewed-by: Matthew Wilcox (Oracle)