From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4648EC433ED for ; Thu, 1 Apr 2021 12:17:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 91720610F8 for ; Thu, 1 Apr 2021 12:17:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91720610F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 247606B0080; Thu, 1 Apr 2021 08:17:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D1A96B0081; Thu, 1 Apr 2021 08:17:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0231F6B0082; Thu, 1 Apr 2021 08:17:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id D6B5A6B0080 for ; Thu, 1 Apr 2021 08:17:09 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7EBFB688B for ; Thu, 1 Apr 2021 12:17:09 +0000 (UTC) X-FDA: 77983697778.07.28A859B Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf23.hostedemail.com (Postfix) with ESMTP id 2B403A0003AE for ; Thu, 1 Apr 2021 12:17:08 +0000 (UTC) Received: by mail-qv1-f46.google.com with SMTP id c3so857861qvz.7 for ; Thu, 01 Apr 2021 05:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=At0hLz31f0qtUzLaHQ2A95j4ugCcCPB956OmXqMS5rs=; b=l7M3Mf6hI23/wkm1ICIFnK4z5S/ekbJFlZIz4UiO3EsuXmT30w9b87KrwixxDKuOge kh27oUqHkyQTSs2iHP2qZJTfRNww1HrJg8hIp7P1s31lVF6sCtzKCNywqazuMljSnbZI VrktpgcxZDu4WVYhVEDtDa0Ycxd6+y0Q+LpRfxZCsL0W7CyTUFoYURX/lUa1BWRBcp4m J6UrzIPeKoG4TVI/D2+yz7jbU0sUzgPRgt/HTkBwnGZRS8mGeHR4/hSpC69G+NWcn9tR mZZm3bLcxk2s7tCtokFiFSwixJsxPoMX0tgcrxy4euObBQjAEpkCWkHE+a5h4GvQzYY2 h10Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=At0hLz31f0qtUzLaHQ2A95j4ugCcCPB956OmXqMS5rs=; b=bkaA171d7utqBp0K0INlafQJxIgD1ujk3XF5Z1epw1oGVtIcqhMvaJLrHYmR0mpFFd PSBYYZfsNR+J7R0O1tKoACJ6lv3pMpKwRqC/AwPiL6BbgTQAXon6ax2ThdPRBbC3oGn8 dq8mtMnUeR5EaDee0atK0bPuFj+I66ejCOEA0HwGeN8IeZKlOx9ESxd3plhZTQzY1ORj uWZkSV1QZBW1f1wahpiYelm14ZF2dLonotmMAz13C1H8CvRS+Q5da8vQ2b43TGeeaGsy V94+LFjyHPerRnnr7QxpsQR0+7wT67BowNtmVW6NQIsT1Fim7CMkENqY5IMXSLvuzh+i nRaA== X-Gm-Message-State: AOAM531/H1/BLvuqQDlJv+ZJfv4YiNlgWn6pYZ8jo3ttS2AF/03VnmQw C4PeAOYkMWreDUGWhUE1yXtYzQ== X-Google-Smtp-Source: ABdhPJxg0Kygm+S1OT+znq+JgIErKthh9M7WdRZCmxr/Gdr15knlJbF92ZospUDVdcnAt+x2LMSZSw== X-Received: by 2002:a05:6214:2689:: with SMTP id gm9mr7853319qvb.42.1617279428419; Thu, 01 Apr 2021 05:17:08 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-115-133.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.115.133]) by smtp.gmail.com with ESMTPSA id q125sm3859775qkf.68.2021.04.01.05.17.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Apr 2021 05:17:07 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1lRwG3-006jas-7b; Thu, 01 Apr 2021 09:17:07 -0300 Date: Thu, 1 Apr 2021 09:17:07 -0300 From: Jason Gunthorpe To: Yang Shi Cc: jhubbard@nvidia.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH] mm: gup: remove FOLL_SPLIT Message-ID: <20210401121707.GZ2710221@ziepe.ca> References: <20210330203900.9222-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330203900.9222-1-shy828301@gmail.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2B403A0003AE X-Stat-Signature: z87u95z91hd5m8s3ngnjsszw3xo3fa8j Received-SPF: none (ziepe.ca>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mail-qv1-f46.google.com; client-ip=209.85.219.46 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617279428-75852 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000026, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 30, 2021 at 01:38:59PM -0700, Yang Shi wrote: > Since commit 5a52c9df62b4 ("uprobe: use FOLL_SPLIT_PMD instead of FOLL_SPLIT") > and commit ba925fa35057 ("s390/gmap: improve THP splitting") FOLL_SPLIT > has not been used anymore. Remove the dead code. > > Reviewed-by: John Hubbard > Signed-off-by: Yang Shi > --- > v2: Remove the reference in documentation. > > Documentation/vm/transhuge.rst | 5 ----- > include/linux/mm.h | 1 - > mm/gup.c | 28 ++-------------------------- > 3 files changed, 2 insertions(+), 32 deletions(-) Reviewed-by: Jason Gunthorpe Jason