From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 971B7C433ED for ; Thu, 1 Apr 2021 07:55:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E74AB61003 for ; Thu, 1 Apr 2021 07:55:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E74AB61003 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6C81D6B0080; Thu, 1 Apr 2021 03:55:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 679BE6B0081; Thu, 1 Apr 2021 03:55:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53FC36B0082; Thu, 1 Apr 2021 03:55:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 36F4F6B0080 for ; Thu, 1 Apr 2021 03:55:07 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D46A9181AF5C3 for ; Thu, 1 Apr 2021 07:55:06 +0000 (UTC) X-FDA: 77983037412.18.AB88A96 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf05.hostedemail.com (Postfix) with ESMTP id B819FE0011E1 for ; Thu, 1 Apr 2021 07:55:05 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 0AFD568B05; Thu, 1 Apr 2021 09:55:03 +0200 (CEST) Date: Thu, 1 Apr 2021 09:55:02 +0200 From: Christoph Hellwig To: Dan Carpenter Cc: kbuild@lists.01.org, Christoph Hellwig , lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Andrew Morton Subject: Re: [linux-next:master 8015/8469] drivers/gpu/drm/i915/i915_mm.c:76 remap_io_sg() error: uninitialized symbol 'err'. Message-ID: <20210401075502.GA28983@lst.de> References: <20210330100152.GC2065@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330100152.GC2065@kadam> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: B819FE0011E1 X-Stat-Signature: ajs9wdr4sdubpcnbnryw8ybbf4hn1dhg X-Rspamd-Server: rspam02 Received-SPF: none (lst.de>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=verein.lst.de; client-ip=213.95.11.211 X-HE-DKIM-Result: none/none X-HE-Tag: 1617263705-662186 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 30, 2021 at 01:01:52PM +0300, Dan Carpenter wrote: > drivers/gpu/drm/i915/i915_mm.c:76 remap_io_sg() error: uninitialized symbol 'err'. Having an SGL where the first entry has a 0 dma_length is not valid. That being said, the trivial patch below will remove the warning and is otherwise harmless, so we could fold it in: diff --git a/drivers/gpu/drm/i915/i915_mm.c b/drivers/gpu/drm/i915/i915_mm.c index 4c8cd08c672d2d..25576fa73ff031 100644 --- a/drivers/gpu/drm/i915/i915_mm.c +++ b/drivers/gpu/drm/i915/i915_mm.c @@ -47,7 +47,7 @@ int remap_io_sg(struct vm_area_struct *vma, struct scatterlist *sgl, resource_size_t iobase) { unsigned long pfn, len, remapped = 0; - int err; + int err = 0; /* We rely on prevalidation of the io-mapping to skip track_pfn(). */ GEM_BUG_ON((vma->vm_flags & EXPECTED_FLAGS) != EXPECTED_FLAGS);