From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34848C433C1 for ; Wed, 31 Mar 2021 09:28:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C0179601FF for ; Wed, 31 Mar 2021 09:28:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0179601FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 49D526B007E; Wed, 31 Mar 2021 05:28:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 474B16B0081; Wed, 31 Mar 2021 05:28:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33C516B0082; Wed, 31 Mar 2021 05:28:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id 1A11E6B007E for ; Wed, 31 Mar 2021 05:28:35 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C86C012F5 for ; Wed, 31 Mar 2021 09:28:34 +0000 (UTC) X-FDA: 77979644148.33.303B085 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf20.hostedemail.com (Postfix) with ESMTP id 30C09DD for ; Wed, 31 Mar 2021 09:28:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0AF7DB34F; Wed, 31 Mar 2021 09:28:33 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 0266B1E4415; Wed, 31 Mar 2021 11:28:29 +0200 (CEST) Date: Wed, 31 Mar 2021 11:28:29 +0200 From: Jan Kara To: "Matthew Wilcox (Oracle)" Cc: Jan Kara , linux-mm@kvack.org, Johannes Weiner Subject: Re: [PATCH 0/3] Allow for multiple pages in a single writeback event Message-ID: <20210331092829.GE30749@quack2.suse.cz> References: <20210322201116.2149432-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210322201116.2149432-1-willy@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 30C09DD X-Stat-Signature: osd651x85minp9mzxzsbhwg1nkdz9dyd Received-SPF: none (suse.cz>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1617182914-445378 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 22-03-21 20:11:13, Matthew Wilcox (Oracle) wrote: > This is prep work for THP or Folios or whatever we end up doing -- > we are going to end up somehow batching page writeback completions. > Nothing here makes that happen; we simply pass '1' from all our current > callers, but eventually we'll pass a number greater than 1. The patches look good to me besides that one problem in the writeback proportions code. After that is fixed, I can either take the patches through my tree or we can route them through Andrew with my Reviewed-by. Honza > > Matthew Wilcox (Oracle) (3): > mm/writeback: Rename __add_wb_stat to wb_stat_mod > flex_proportions: Allow N events instead of 1 > mm/writeback: Change __wb_writeout_inc to __wb_writeout_add > > include/linux/backing-dev.h | 6 +++--- > include/linux/flex_proportions.h | 9 +++++---- > lib/flex_proportions.c | 15 ++++++++------- > mm/page-writeback.c | 24 ++++++++++++------------ > 4 files changed, 28 insertions(+), 26 deletions(-) > > -- > 2.30.2 > -- Jan Kara SUSE Labs, CR