From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F1FDC433DB for ; Fri, 26 Mar 2021 01:48:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 97B326197C for ; Fri, 26 Mar 2021 01:48:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97B326197C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 04A856B0036; Thu, 25 Mar 2021 21:48:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3CC16B006E; Thu, 25 Mar 2021 21:48:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8ECB6B0070; Thu, 25 Mar 2021 21:48:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id B3E456B0036 for ; Thu, 25 Mar 2021 21:48:45 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 795AEA8C0 for ; Fri, 26 Mar 2021 01:48:45 +0000 (UTC) X-FDA: 77960341410.03.B94A101 Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by imf06.hostedemail.com (Postfix) with ESMTP id 06E9CC0007C8 for ; Fri, 26 Mar 2021 01:48:32 +0000 (UTC) Received: from ambrosehua-HP-xw6600-Workstation (unknown [182.149.160.162]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9CxQ+BTPV1gi+MAAA--.881S2; Fri, 26 Mar 2021 09:48:05 +0800 (CST) Date: Fri, 26 Mar 2021 09:48:03 +0800 From: Huang Pei To: Steven Rostedt Cc: Thomas Bogendoerfer , ambrosehua@gmail.com, Bibo Mao , linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Jiaxun Yang , Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Jinyang He , "Maciej W . Rozycki" , Jisheng Zhang , Masami Hiramatsu Subject: Re: [PATCH 1/6] MIPS: replace -pg with CC_FLAGS_FTRACE Message-ID: <20210326014802.fkdiggo3tak6j5it@ambrosehua-HP-xw6600-Workstation> References: <20210313064149.29276-1-huangpei@loongson.cn> <20210313064149.29276-2-huangpei@loongson.cn> <20210325153814.098a5d32@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325153814.098a5d32@gandalf.local.home> User-Agent: NeoMutt/20171215 X-CM-TRANSID:AQAAf9CxQ+BTPV1gi+MAAA--.881S2 X-Coremail-Antispam: 1UD129KBjvJXoWxAFW8tr1fArWkJF1UZw4Dtwb_yoW5CFy3pa n2kF1DJw4xXry8KryftFy5ZrsrArZYqrW0gFnFgryUtF9xZFnYgr1xtry5XF95WryxA34x Wa48WF17Aryava7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvK14x267AKxVW5JVWrJwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26F 4UJVW0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r 1j6r4UM4x0Y48IcVAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v n2kIc2xKxwCY02Avz4vE14v_KwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJV W8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF 1VAFwI0_GFv_WrylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6x IIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF 0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxh VjvjDU0xZFpf9x0JUWa0PUUUUU= X-CM-SenderInfo: xkxd0whshlqz5rrqw2lrqou0/ X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 06E9CC0007C8 X-Stat-Signature: irg6gfeoasxkzz6saq8mm5rwspjifxuy Received-SPF: none (loongson.cn>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=loongson.cn; client-ip=114.242.206.163 X-HE-DKIM-Result: none/none X-HE-Tag: 1616723312-804118 X-Bogosity: Ham, tests=bogofilter, spamicity=0.043702, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 25, 2021 at 03:38:14PM -0400, Steven Rostedt wrote: > On Sat, 13 Mar 2021 14:41:44 +0800 > Huang Pei wrote: > > > Even simple changes require change logs. For example: > > "Enabling ftrace may require more than just the -pg flags today. As ftrace > enables more flags, use the $(CC_FLAGS_FTRACE) in the make file instead of > hard coding "-pg"." > > Other than that: > > Acked-by: Steven Rostedt (VMware) > > -- Steve > Got it, much better than mine, thank you > > > Signed-off-by: Huang Pei > > --- > > arch/mips/boot/compressed/Makefile | 2 +- > > arch/mips/kernel/Makefile | 8 ++++---- > > arch/mips/vdso/Makefile | 4 ++-- > > 3 files changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/arch/mips/boot/compressed/Makefile b/arch/mips/boot/compressed/Makefile > > index d66511825fe1..8fc9ceeec709 100644 > > --- a/arch/mips/boot/compressed/Makefile > > +++ b/arch/mips/boot/compressed/Makefile > > @@ -18,7 +18,7 @@ include $(srctree)/arch/mips/Kbuild.platforms > > BOOT_HEAP_SIZE := 0x400000 > > > > # Disable Function Tracer > > -KBUILD_CFLAGS := $(filter-out -pg, $(KBUILD_CFLAGS)) > > +KBUILD_CFLAGS := $(filter-out $(CC_FLAGS_FTRACE), $(KBUILD_CFLAGS)) > > > > KBUILD_CFLAGS := $(filter-out -fstack-protector, $(KBUILD_CFLAGS)) > > > > diff --git a/arch/mips/kernel/Makefile b/arch/mips/kernel/Makefile > > index 2a05b923f579..33e31ea10234 100644 > > --- a/arch/mips/kernel/Makefile > > +++ b/arch/mips/kernel/Makefile > > @@ -17,10 +17,10 @@ obj-y += cpu-probe.o > > endif > > > > ifdef CONFIG_FUNCTION_TRACER > > -CFLAGS_REMOVE_ftrace.o = -pg > > -CFLAGS_REMOVE_early_printk.o = -pg > > -CFLAGS_REMOVE_perf_event.o = -pg > > -CFLAGS_REMOVE_perf_event_mipsxx.o = -pg > > +CFLAGS_REMOVE_ftrace.o = $(CC_FLAGS_FTRACE) > > +CFLAGS_REMOVE_early_printk.o = $(CC_FLAGS_FTRACE) > > +CFLAGS_REMOVE_perf_event.o = $(CC_FLAGS_FTRACE) > > +CFLAGS_REMOVE_perf_event_mipsxx.o = $(CC_FLAGS_FTRACE) > > endif > > > > obj-$(CONFIG_CEVT_BCM1480) += cevt-bcm1480.o > > diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile > > index 5810cc12bc1d..f21cf88f7ae3 100644 > > --- a/arch/mips/vdso/Makefile > > +++ b/arch/mips/vdso/Makefile > > @@ -49,7 +49,7 @@ CFLAGS_vgettimeofday-o32.o = -include $(srctree)/$(src)/config-n32-o32-env.c -in > > CFLAGS_vgettimeofday-n32.o = -include $(srctree)/$(src)/config-n32-o32-env.c -include $(c-gettimeofday-y) > > endif > > > > -CFLAGS_REMOVE_vgettimeofday.o = -pg > > +CFLAGS_REMOVE_vgettimeofday.o = $(CC_FLAGS_FTRACE) > > > > ifdef CONFIG_MIPS_DISABLE_VDSO > > ifndef CONFIG_MIPS_LD_CAN_LINK_VDSO > > @@ -63,7 +63,7 @@ ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \ > > $(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared \ > > -G 0 --eh-frame-hdr --hash-style=sysv --build-id=sha1 -T > > > > -CFLAGS_REMOVE_vdso.o = -pg > > +CFLAGS_REMOVE_vdso.o = $(CC_FLAGS_FTRACE) > > > > GCOV_PROFILE := n > > UBSAN_SANITIZE := n