From: Huang Pei <huangpei@loongson.cn>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
ambrosehua@gmail.com, Bibo Mao <maobibo@loongson.cn>,
linux-mips@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
Paul Burton <paulburton@kernel.org>,
Li Xuefeng <lixuefeng@loongson.cn>,
Yang Tiezhu <yangtiezhu@loongson.cn>,
Gao Juxin <gaojuxin@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>,
Jinyang He <hejinyang@loongson.cn>,
"Maciej W . Rozycki" <macro@orcam.me.uk>,
Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH 1/6] MIPS: replace -pg with CC_FLAGS_FTRACE
Date: Fri, 26 Mar 2021 09:48:03 +0800 [thread overview]
Message-ID: <20210326014802.fkdiggo3tak6j5it@ambrosehua-HP-xw6600-Workstation> (raw)
In-Reply-To: <20210325153814.098a5d32@gandalf.local.home>
On Thu, Mar 25, 2021 at 03:38:14PM -0400, Steven Rostedt wrote:
> On Sat, 13 Mar 2021 14:41:44 +0800
> Huang Pei <huangpei@loongson.cn> wrote:
>
>
> Even simple changes require change logs. For example:
>
> "Enabling ftrace may require more than just the -pg flags today. As ftrace
> enables more flags, use the $(CC_FLAGS_FTRACE) in the make file instead of
> hard coding "-pg"."
>
> Other than that:
>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> -- Steve
>
Got it, much better than mine, thank you
>
> > Signed-off-by: Huang Pei <huangpei@loongson.cn>
> > ---
> > arch/mips/boot/compressed/Makefile | 2 +-
> > arch/mips/kernel/Makefile | 8 ++++----
> > arch/mips/vdso/Makefile | 4 ++--
> > 3 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/mips/boot/compressed/Makefile b/arch/mips/boot/compressed/Makefile
> > index d66511825fe1..8fc9ceeec709 100644
> > --- a/arch/mips/boot/compressed/Makefile
> > +++ b/arch/mips/boot/compressed/Makefile
> > @@ -18,7 +18,7 @@ include $(srctree)/arch/mips/Kbuild.platforms
> > BOOT_HEAP_SIZE := 0x400000
> >
> > # Disable Function Tracer
> > -KBUILD_CFLAGS := $(filter-out -pg, $(KBUILD_CFLAGS))
> > +KBUILD_CFLAGS := $(filter-out $(CC_FLAGS_FTRACE), $(KBUILD_CFLAGS))
> >
> > KBUILD_CFLAGS := $(filter-out -fstack-protector, $(KBUILD_CFLAGS))
> >
> > diff --git a/arch/mips/kernel/Makefile b/arch/mips/kernel/Makefile
> > index 2a05b923f579..33e31ea10234 100644
> > --- a/arch/mips/kernel/Makefile
> > +++ b/arch/mips/kernel/Makefile
> > @@ -17,10 +17,10 @@ obj-y += cpu-probe.o
> > endif
> >
> > ifdef CONFIG_FUNCTION_TRACER
> > -CFLAGS_REMOVE_ftrace.o = -pg
> > -CFLAGS_REMOVE_early_printk.o = -pg
> > -CFLAGS_REMOVE_perf_event.o = -pg
> > -CFLAGS_REMOVE_perf_event_mipsxx.o = -pg
> > +CFLAGS_REMOVE_ftrace.o = $(CC_FLAGS_FTRACE)
> > +CFLAGS_REMOVE_early_printk.o = $(CC_FLAGS_FTRACE)
> > +CFLAGS_REMOVE_perf_event.o = $(CC_FLAGS_FTRACE)
> > +CFLAGS_REMOVE_perf_event_mipsxx.o = $(CC_FLAGS_FTRACE)
> > endif
> >
> > obj-$(CONFIG_CEVT_BCM1480) += cevt-bcm1480.o
> > diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile
> > index 5810cc12bc1d..f21cf88f7ae3 100644
> > --- a/arch/mips/vdso/Makefile
> > +++ b/arch/mips/vdso/Makefile
> > @@ -49,7 +49,7 @@ CFLAGS_vgettimeofday-o32.o = -include $(srctree)/$(src)/config-n32-o32-env.c -in
> > CFLAGS_vgettimeofday-n32.o = -include $(srctree)/$(src)/config-n32-o32-env.c -include $(c-gettimeofday-y)
> > endif
> >
> > -CFLAGS_REMOVE_vgettimeofday.o = -pg
> > +CFLAGS_REMOVE_vgettimeofday.o = $(CC_FLAGS_FTRACE)
> >
> > ifdef CONFIG_MIPS_DISABLE_VDSO
> > ifndef CONFIG_MIPS_LD_CAN_LINK_VDSO
> > @@ -63,7 +63,7 @@ ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \
> > $(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared \
> > -G 0 --eh-frame-hdr --hash-style=sysv --build-id=sha1 -T
> >
> > -CFLAGS_REMOVE_vdso.o = -pg
> > +CFLAGS_REMOVE_vdso.o = $(CC_FLAGS_FTRACE)
> >
> > GCOV_PROFILE := n
> > UBSAN_SANITIZE := n
next prev parent reply other threads:[~2021-03-26 1:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 6:41 [RFC PATCH V2]: add DYNAMC_FTRACE_WITH_REGS and Huang Pei
2021-03-13 6:41 ` [PATCH 1/6] MIPS: replace -pg with CC_FLAGS_FTRACE Huang Pei
2021-03-25 19:38 ` Steven Rostedt
2021-03-26 1:48 ` Huang Pei [this message]
2021-03-13 6:41 ` [PATCH 2/6] MIPS: move FTRACE_SYSCALLS from ftrace.c into syscall.c Huang Pei
2021-03-25 19:38 ` Steven Rostedt
2021-03-26 14:01 ` Huang Pei
2021-03-13 6:41 ` [PATCH 3/6] MIPS: prepare for new ftrace implementation Huang Pei
2021-03-25 19:39 ` Steven Rostedt
2021-03-13 6:41 ` [PATCH 4/6] kprobes/ftrace: Use ftrace_location() when [dis]arming probes Huang Pei
2021-03-25 19:44 ` Steven Rostedt
2021-03-26 14:12 ` Huang Pei
2021-03-26 14:23 ` Steven Rostedt
2021-03-13 6:41 ` [PATCH 5/6] ftrace: introduce FTRACE_IP_EXTENSION Huang Pei
2021-03-13 9:26 ` Sergei Shtylyov
2021-03-13 6:41 ` [PATCH 6/6] MIPS: add DYNAMIC_FTRACE_WITH_REGS and KPROBES_ON_FTACE Huang Pei
2021-03-13 21:37 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326014802.fkdiggo3tak6j5it@ambrosehua-HP-xw6600-Workstation \
--to=huangpei@loongson.cn \
--cc=Jisheng.Zhang@synaptics.com \
--cc=ambrosehua@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=gaojuxin@loongson.cn \
--cc=hejinyang@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lixuefeng@loongson.cn \
--cc=macro@orcam.me.uk \
--cc=maobibo@loongson.cn \
--cc=mhiramat@kernel.org \
--cc=paulburton@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tsbogend@alpha.franken.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox