From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C10AC433E0 for ; Thu, 25 Mar 2021 15:51:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2E27261A11 for ; Thu, 25 Mar 2021 15:51:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E27261A11 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B032D6B0071; Thu, 25 Mar 2021 11:50:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB37C6B0072; Thu, 25 Mar 2021 11:50:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97B1C6B0073; Thu, 25 Mar 2021 11:50:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 7CBD56B0071 for ; Thu, 25 Mar 2021 11:50:59 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 34B4818253F0D for ; Thu, 25 Mar 2021 15:50:59 +0000 (UTC) X-FDA: 77958835038.19.4198FA7 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf17.hostedemail.com (Postfix) with ESMTP id EAA3F40002D0 for ; Thu, 25 Mar 2021 15:50:56 +0000 (UTC) IronPort-SDR: FtqgOqTqBO7Y3AABJqCqBSKF7QkcUx13cXmdZB5KKB44sFOP6wQHTzZpO5LuSZyTjiMEHtRsg4 srsKpZq6HKig== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="190988734" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="190988734" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 08:50:34 -0700 IronPort-SDR: 2D287W8HdKRaaY1/5QQFUtCmKDOIARrCGX3QeinOnSGrnxSd6WrbztYo82+850oeDy/6j6WKwY 5l6flh+r6xsQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="375121834" Received: from lkp-server01.sh.intel.com (HELO 69d8fcc516b7) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 25 Mar 2021 08:50:33 -0700 Received: from kbuild by 69d8fcc516b7 with local (Exim 4.92) (envelope-from ) id 1lPSFk-00025S-Da; Thu, 25 Mar 2021 15:50:32 +0000 Date: Thu, 25 Mar 2021 23:49:56 +0800 From: kernel test robot To: Dario Pagani Cc: kbuild-all@lists.01.org, Linux Memory Management List , Jiri Kosina , Kim Kuparinen Subject: [PATCH] HID: fix memdup.cocci warnings Message-ID: <20210325154956.GA35356@f923dd4e708e> References: <202103252348.wD7w1qG9-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202103252348.wD7w1qG9-lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: mautyxbn5rh3bsfoobjadyjubcui4qh5 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EAA3F40002D0 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=mga03.intel.com; client-ip=134.134.136.65 X-HE-DKIM-Result: none/none X-HE-Tag: 1616687456-493714 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: kernel test robot drivers/hid/hid-thrustmaster.c:300:27-34: WARNING opportunity for kmemdup Use kmemdup rather than duplicating its implementation Generated by: scripts/coccinelle/api/memdup.cocci Fixes: c49c33637802 ("HID: support for initialization of some Thrustmaster wheels") CC: Dario Pagani Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: b4f20b70784aabf97e1727561e775500f6e294c7 commit: c49c33637802a2c6957a78119eb8be3b055dd9e9 [4793/7299] HID: support for initialization of some Thrustmaster wheels hid-thrustmaster.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/hid/hid-thrustmaster.c +++ b/drivers/hid/hid-thrustmaster.c @@ -297,12 +297,13 @@ static int thrustmaster_probe(struct hid goto error2; } - tm_wheel->model_request = kzalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL); + tm_wheel->model_request = kmemdup(&model_request, + sizeof(struct usb_ctrlrequest), + GFP_KERNEL); if (!tm_wheel->model_request) { ret = -ENOMEM; goto error3; } - memcpy(tm_wheel->model_request, &model_request, sizeof(struct usb_ctrlrequest)); tm_wheel->response = kzalloc(sizeof(struct tm_wheel_response), GFP_KERNEL); if (!tm_wheel->response) {