Re: [PATCH 3/6] MIPS: prepare for new ftrace implementation

[Steven Rostedt <rostedt@goodmis.org>]

On Sat, 13 Mar 2021 14:41:46 +0800
Huang Pei <huangpei@loongson.cn> wrote:

> No function change

Change logs require rationale for the change. Why is this being done? Just
saying "No function change" is not informative at all.

-- Steve


> 
> Signed-off-by: Huang Pei <huangpei@loongson.cn>
> ---
>  arch/mips/kernel/Makefile                      | 4 ++--
>  arch/mips/kernel/{ftrace.c => ftrace-mcount.c} | 0
>  2 files changed, 2 insertions(+), 2 deletions(-)
>  rename arch/mips/kernel/{ftrace.c => ftrace-mcount.c} (100%)
> 
> diff --git a/arch/mips/kernel/Makefile b/arch/mips/kernel/Makefile
> index 5b2b551058ac..3e7b0ee54cfb 100644
> --- a/arch/mips/kernel/Makefile
> +++ b/arch/mips/kernel/Makefile
> @@ -17,7 +17,7 @@ obj-y		+= cpu-probe.o
>  endif
>  
>  ifdef CONFIG_FUNCTION_TRACER
> -CFLAGS_REMOVE_ftrace.o = $(CC_FLAGS_FTRACE)
> +CFLAGS_REMOVE_ftrace-mcount.o = $(CC_FLAGS_FTRACE)
>  CFLAGS_REMOVE_early_printk.o = $(CC_FLAGS_FTRACE)
>  CFLAGS_REMOVE_perf_event.o = $(CC_FLAGS_FTRACE)
>  CFLAGS_REMOVE_perf_event_mipsxx.o = $(CC_FLAGS_FTRACE)
> @@ -39,7 +39,7 @@ obj-$(CONFIG_DEBUG_FS)		+= segment.o
>  obj-$(CONFIG_STACKTRACE)	+= stacktrace.o
>  obj-$(CONFIG_MODULES)		+= module.o
>  
> -obj-$(CONFIG_FUNCTION_TRACER)	+= mcount.o ftrace.o
> +obj-$(CONFIG_FUNCTION_TRACER)	+= mcount.o ftrace-mcount.o
>  
>  sw-y				:= r4k_switch.o
>  sw-$(CONFIG_CPU_R3000)		:= r2300_switch.o
> diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace-mcount.c
> similarity index 100%
> rename from arch/mips/kernel/ftrace.c
> rename to arch/mips/kernel/ftrace-mcount.c