From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D6DC433DB for ; Thu, 25 Mar 2021 19:38:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38F0E61A31 for ; Thu, 25 Mar 2021 19:38:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38F0E61A31 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C26FC6B006C; Thu, 25 Mar 2021 15:38:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB0696B006E; Thu, 25 Mar 2021 15:38:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A02806B0070; Thu, 25 Mar 2021 15:38:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 804736B006C for ; Thu, 25 Mar 2021 15:38:22 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4273811234 for ; Thu, 25 Mar 2021 19:38:22 +0000 (UTC) X-FDA: 77959408044.12.157AA10 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf20.hostedemail.com (Postfix) with ESMTP id B3B7DF9 for ; Thu, 25 Mar 2021 19:38:18 +0000 (UTC) Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5ED5561A32; Thu, 25 Mar 2021 19:38:16 +0000 (UTC) Date: Thu, 25 Mar 2021 15:38:14 -0400 From: Steven Rostedt To: Huang Pei Cc: Thomas Bogendoerfer , ambrosehua@gmail.com, Bibo Mao , linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Jiaxun Yang , Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Jinyang He , "Maciej W . Rozycki" , Jisheng Zhang , Masami Hiramatsu Subject: Re: [PATCH 1/6] MIPS: replace -pg with CC_FLAGS_FTRACE Message-ID: <20210325153814.098a5d32@gandalf.local.home> In-Reply-To: <20210313064149.29276-2-huangpei@loongson.cn> References: <20210313064149.29276-1-huangpei@loongson.cn> <20210313064149.29276-2-huangpei@loongson.cn> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: fzjomd4sjbn9pe4qfs1uogxntahz8xqq X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B3B7DF9 Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: none/none X-HE-Tag: 1616701098-376724 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001649, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 13 Mar 2021 14:41:44 +0800 Huang Pei wrote: Even simple changes require change logs. For example: "Enabling ftrace may require more than just the -pg flags today. As ftrace enables more flags, use the $(CC_FLAGS_FTRACE) in the make file instead of hard coding "-pg"." Other than that: Acked-by: Steven Rostedt (VMware) -- Steve > Signed-off-by: Huang Pei > --- > arch/mips/boot/compressed/Makefile | 2 +- > arch/mips/kernel/Makefile | 8 ++++---- > arch/mips/vdso/Makefile | 4 ++-- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/mips/boot/compressed/Makefile b/arch/mips/boot/compressed/Makefile > index d66511825fe1..8fc9ceeec709 100644 > --- a/arch/mips/boot/compressed/Makefile > +++ b/arch/mips/boot/compressed/Makefile > @@ -18,7 +18,7 @@ include $(srctree)/arch/mips/Kbuild.platforms > BOOT_HEAP_SIZE := 0x400000 > > # Disable Function Tracer > -KBUILD_CFLAGS := $(filter-out -pg, $(KBUILD_CFLAGS)) > +KBUILD_CFLAGS := $(filter-out $(CC_FLAGS_FTRACE), $(KBUILD_CFLAGS)) > > KBUILD_CFLAGS := $(filter-out -fstack-protector, $(KBUILD_CFLAGS)) > > diff --git a/arch/mips/kernel/Makefile b/arch/mips/kernel/Makefile > index 2a05b923f579..33e31ea10234 100644 > --- a/arch/mips/kernel/Makefile > +++ b/arch/mips/kernel/Makefile > @@ -17,10 +17,10 @@ obj-y += cpu-probe.o > endif > > ifdef CONFIG_FUNCTION_TRACER > -CFLAGS_REMOVE_ftrace.o = -pg > -CFLAGS_REMOVE_early_printk.o = -pg > -CFLAGS_REMOVE_perf_event.o = -pg > -CFLAGS_REMOVE_perf_event_mipsxx.o = -pg > +CFLAGS_REMOVE_ftrace.o = $(CC_FLAGS_FTRACE) > +CFLAGS_REMOVE_early_printk.o = $(CC_FLAGS_FTRACE) > +CFLAGS_REMOVE_perf_event.o = $(CC_FLAGS_FTRACE) > +CFLAGS_REMOVE_perf_event_mipsxx.o = $(CC_FLAGS_FTRACE) > endif > > obj-$(CONFIG_CEVT_BCM1480) += cevt-bcm1480.o > diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile > index 5810cc12bc1d..f21cf88f7ae3 100644 > --- a/arch/mips/vdso/Makefile > +++ b/arch/mips/vdso/Makefile > @@ -49,7 +49,7 @@ CFLAGS_vgettimeofday-o32.o = -include $(srctree)/$(src)/config-n32-o32-env.c -in > CFLAGS_vgettimeofday-n32.o = -include $(srctree)/$(src)/config-n32-o32-env.c -include $(c-gettimeofday-y) > endif > > -CFLAGS_REMOVE_vgettimeofday.o = -pg > +CFLAGS_REMOVE_vgettimeofday.o = $(CC_FLAGS_FTRACE) > > ifdef CONFIG_MIPS_DISABLE_VDSO > ifndef CONFIG_MIPS_LD_CAN_LINK_VDSO > @@ -63,7 +63,7 @@ ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \ > $(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared \ > -G 0 --eh-frame-hdr --hash-style=sysv --build-id=sha1 -T > > -CFLAGS_REMOVE_vdso.o = -pg > +CFLAGS_REMOVE_vdso.o = $(CC_FLAGS_FTRACE) > > GCOV_PROFILE := n > UBSAN_SANITIZE := n