From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFEBDC433DB for ; Tue, 23 Mar 2021 17:18:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 69A8160200 for ; Tue, 23 Mar 2021 17:18:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69A8160200 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 062A06B0271; Tue, 23 Mar 2021 13:18:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 039376B0273; Tue, 23 Mar 2021 13:18:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E43736B0274; Tue, 23 Mar 2021 13:18:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id CADA06B0271 for ; Tue, 23 Mar 2021 13:18:43 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 804C63656 for ; Tue, 23 Mar 2021 17:18:43 +0000 (UTC) X-FDA: 77951798526.10.2F20DA6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 63A89E007A44 for ; Tue, 23 Mar 2021 17:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=825tfiSvqVacuyUEuxcQyTkRHvhtiZqC5C0oGwhAk3U=; b=IG2hdbEj73cEqAaxuioR7niNeI eqG1gXQAJVxT1kpo4kcup5UnZicObPInYv4eDJ8Ld29xgpZMBMhpzxGNES60Me+UllXJkUMcBiNO3 duMiNk3uU2rytKtK6XZl32zaLE/DdNIw0awSb2/IZwDgK2VjMBKx5y5YdkoVxFRT/6fHtbQg7xZZn oDniuLcSPc6zeprWrYQ6tASZ0TSyib0eQX0S2QSm8nvCOf/NSqyNHpYbxVNAVIjwxnK6xvf6j/WT2 8ExfuazMO5TN2jAbi+WJga4xVTaXJgO+pytn+14NREcYZrmu0Hc5LSs+omtUwOjtwxxo6g/UKNFsr eK60zCDg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lOkNh-00AJUl-3C; Tue, 23 Mar 2021 17:00:02 +0000 Date: Tue, 23 Mar 2021 16:59:49 +0000 From: Christoph Hellwig To: Jason Gunthorpe Cc: "Thomas Hellstr??m (Intel)" , dri-devel@lists.freedesktop.org, Christian Koenig , David Airlie , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages Message-ID: <20210323165949.GA2457820@infradead.org> References: <20210321184529.59006-1-thomas_os@shipmail.org> <20210321184529.59006-2-thomas_os@shipmail.org> <314fc020-d243-dbf0-acb3-ecfcc9c2443c@shipmail.org> <20210323163715.GJ2356281@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210323163715.GJ2356281@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: cjxhc9tt7nw8aof44nmbhteky3px9bxz X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 63A89E007A44 Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf13; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616519914-372281 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 23, 2021 at 01:37:15PM -0300, Jason Gunthorpe wrote: > Isn't the devmap PTE flag arch optional? Does this fall back to not > using huge pages on arches that don't support it? > > Also, I feel like this code to install "pte_special" huge pages does > not belong in the drm subsystem.. It doesn't. Unfortunately the drm code has a lot of such warts where it pokes way to deep into VM internals.