From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6858EC433C1 for ; Mon, 22 Mar 2021 10:46:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE37C6191E for ; Mon, 22 Mar 2021 10:46:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE37C6191E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CFE836B00AA; Mon, 22 Mar 2021 06:27:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAEB06B00AC; Mon, 22 Mar 2021 06:27:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B14316B00AD; Mon, 22 Mar 2021 06:27:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id 94C036B00AA for ; Mon, 22 Mar 2021 06:27:20 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 074843634 for ; Mon, 22 Mar 2021 10:46:11 +0000 (UTC) X-FDA: 77947180542.14.281513C Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf12.hostedemail.com (Postfix) with ESMTP id 91D06132 for ; Mon, 22 Mar 2021 10:46:10 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id o10so20470749lfb.9 for ; Mon, 22 Mar 2021 03:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YVhaX9TyJpOCjZ6lAAx4X7Evu71S5QgfpSg+uRC3XiQ=; b=M6jX3QVPO2UvJpsu3y0kv19VW5H79eVHUQvu9oD8AlEmyUmNNKBqbG0M9SlNIvKW1A j4HrUVwhPDK8XJkQb2YtadImTHZFIu+ZiV2CiY4VqPwXdbkbI/JEcbsz/1ysRzNkUGqm YCnNWVY5+wV8jyvDHq1hQJj647gMtGG8cTL9qnbbrc4R2mfABoXP185LrniGGhgOBl/e qE8Y2JCCUVVLVun6uiSqkngNMyVNRC9Zg/lBqOFWSItWSDvOVD/M0CWxh0J28yYm/R9J xKgmf9d5Z4dye+vyvIqCw6pxvy7dzPyFYk/ksskR9lwXAIK9kT/ZafHhgk+INpAYlx2n j88g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YVhaX9TyJpOCjZ6lAAx4X7Evu71S5QgfpSg+uRC3XiQ=; b=iEfoz8uCKTaJuWiWVzrY0NCTOU8+7sj/6n/vVU6jBGzivA9X3HrDqPk9I0tfasm73w BxYf8pakTgzl15pUw+3qot03PHcPDVlcX7G1JTZS9gMQECU2M2VlFTgnTzYCZX2LXEbe oKOH0Wh9oVXOG/7mWdplu1I8eIe3BQ1zVRPbj9sHpDerW5rj81xqwwPMWh2Vr8IMojis C1dcWyKw6Pd8DNqbJ+doRKzisuDQruY3dqFqmZMv8DZM4IgLtnPvo7U+eH8YQ7xr9Gm8 VWkzMzt6XWXA0SMJyxWk4guTXtusROb2i5kNB2ULfl1bS9OjvarOkEOO4dxB15rmkCyK WEVg== X-Gm-Message-State: AOAM531FsnJeH/L1vGwgzzmlYyjtolofX7MzrAJ7IFySMmvUpEx754Bx 5ZJOJR7s/xfaah6qXGzB9HAESw== X-Google-Smtp-Source: ABdhPJzLM+bmJsvaTQY9QrPsDTclu+7bOjKDoiq6hBThy6PKFfc4RTvbqhPQkPHx8PacTz+LlaoISw== X-Received: by 2002:a05:6512:219:: with SMTP id a25mr6170751lfo.222.1616409969171; Mon, 22 Mar 2021 03:46:09 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id v80sm1531541lfa.229.2021.03.22.03.46.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 03:46:08 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 32D84101DEB; Mon, 22 Mar 2021 13:46:16 +0300 (+03) Date: Mon, 22 Mar 2021 13:46:16 +0300 From: "Kirill A. Shutemov" To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang Subject: Re: [PATCH v23 15/28] x86/mm: Update maybe_mkwrite() for shadow stack Message-ID: <20210322104616.tht6flrxif257fdb@box> References: <20210316151054.5405-1-yu-cheng.yu@intel.com> <20210316151054.5405-16-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316151054.5405-16-yu-cheng.yu@intel.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 91D06132 X-Stat-Signature: 9h81a874jdfkqp1ff7xmdxf9pxpcasaf Received-SPF: none (shutemov.name>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=mail-lf1-f53.google.com; client-ip=209.85.167.53 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616409970-132509 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 16, 2021 at 08:10:41AM -0700, Yu-cheng Yu wrote: > diff --git a/include/linux/mm.h b/include/linux/mm.h > index a6c18c5752d6..af805ffde48e 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -997,6 +997,8 @@ static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma) > { > if (likely(vma->vm_flags & VM_WRITE)) > pte = pte_mkwrite(pte); > + else > + pte = arch_maybe_mkwrite(pte, vma); > return pte; > } I think it would be cleaner to allow arch code to override maybe_mkwrite() and maybe_pmd_mkwrite() altogether. Wrap it into #ifndef maybe_mkwrite here and provide VM_SHSTK-aware version from . -- Kirill A. Shutemov