From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA173C433DB for ; Mon, 22 Mar 2021 08:09:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5E5FE60233 for ; Mon, 22 Mar 2021 08:09:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E5FE60233 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 378488D0002; Mon, 22 Mar 2021 03:51:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33A508D0001; Mon, 22 Mar 2021 03:51:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F32F8D0002; Mon, 22 Mar 2021 03:51:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0006.hostedemail.com [216.40.44.6]) by kanga.kvack.org (Postfix) with ESMTP id 064028D0001 for ; Mon, 22 Mar 2021 03:51:03 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 60CC112D1 for ; Mon, 22 Mar 2021 08:09:53 +0000 (UTC) X-FDA: 77946786666.16.94D2900 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 3FB1480192EA for ; Mon, 22 Mar 2021 08:09:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0Gom5lIOcdXHDFkwwTX/JWMweB4RudLWTzTu1Kol3XM=; b=JyJG6OQw9jHUMAM4Ha8nIensbI 9fZiw/I5PHU+KACQauDg9T+mvu6hIIUAwAXbWasK7pdDRaKG98c2hqagwjW6Ay1hIKXKnFNc2p26o BId9OrjcFEM5zhFLk9MMy6f6kGnEeXar1ZVotYRwHdZ5zBVMIZgToOz36vhi7lffHa+KFbJy2v09a e8TyGo2crikf1T/fodSFlmVdvvk30haS4s95hnoSh+41au08sn8ScErTl58edbOIyZKJHKUAUUIhx Lm33TT6XoLTpBOnLqhqFKKZM2Nk5r56IXwWL5vaJSjRD34k/rRMfvJ7Nht+Ov2NcRl2dipUfU9O3Y M8zY187A==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lOFcB-008BcB-Vl; Mon, 22 Mar 2021 08:09:01 +0000 Date: Mon, 22 Mar 2021 08:08:43 +0000 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v5 03/27] afs: Use wait_on_page_writeback_killable Message-ID: <20210322080843.GD1946905@infradead.org> References: <20210320054104.1300774-1-willy@infradead.org> <20210320054104.1300774-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210320054104.1300774-4-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: btsmwf38x9n8g6bek39k1x4sn51x9ygx X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3FB1480192EA Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616400587-427299 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 20, 2021 at 05:40:40AM +0000, Matthew Wilcox (Oracle) wrote: > Open-coding this function meant it missed out on the recent bugfix > for waiters being woken by a delayed wake event from a previous > instantiation of the page. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig