From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE6A3C433C1 for ; Mon, 22 Mar 2021 08:07:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 454BD61585 for ; Mon, 22 Mar 2021 08:07:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 454BD61585 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EEDAC8D0002; Mon, 22 Mar 2021 03:48:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9E4E8D0001; Mon, 22 Mar 2021 03:48:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D65188D0002; Mon, 22 Mar 2021 03:48:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id BA2DD8D0001 for ; Mon, 22 Mar 2021 03:48:45 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 27F5D1E1F for ; Mon, 22 Mar 2021 08:07:36 +0000 (UTC) X-FDA: 77946780870.25.5954F64 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id 646A4C0007C3 for ; Mon, 22 Mar 2021 08:07:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TbYveShLYeVqBDd6OuMK3KKplXpJFMY9UQBn/f/mXuk=; b=oUINOzWNzUdAROCRX5M78JAJO+ HoCGe1ia4mvzSj9k8yi/ZlT/4E14wgYfKSCd7VnoLGoT3+IeEiDZvgBu7dSfnzQ/+dk8xDLcENX6t T62vKVi6lP7Dxtk5Y7hMV42i54rIMh6BieObBd3sq8YrAUWxADN7eE8bILypdhoQfZt10ko2R5kmP FKRNEfQbbbxfKutmUNBnmE8VRp3WnpG4d2p/U029bk06ERSvFupgAaZH7ekvMTRw0abD/XlT2e6WN VYmPuXFM5fy/UxIc03SwLmBfIoqM0/miKbVR1dK4DsvopqYGUZ4VPQRjREXIsd9EY31n3bI0MpaII aqQPm2Lg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lOFaM-008BRm-9O; Mon, 22 Mar 2021 08:06:55 +0000 Date: Mon, 22 Mar 2021 08:06:50 +0000 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v5 01/27] fs/cachefiles: Remove wait_bit_key layout dependency Message-ID: <20210322080650.GB1946905@infradead.org> References: <20210320054104.1300774-1-willy@infradead.org> <20210320054104.1300774-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210320054104.1300774-2-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 646A4C0007C3 X-Stat-Signature: 6e71hmg54de5mz4ju79o9tea4wun33ag Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616400455-195414 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 20, 2021 at 05:40:38AM +0000, Matthew Wilcox (Oracle) wrote: > Cachefiles was relying on wait_page_key and wait_bit_key being the > same layout, which is fragile. Now that wait_page_key is exposed in > the pagemap.h header, we can remove that fragility > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig