From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD55C433DB for ; Sat, 20 Mar 2021 16:32:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B21A561946 for ; Sat, 20 Mar 2021 16:32:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B21A561946 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 523386B007B; Sat, 20 Mar 2021 12:32:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E78B6B007E; Sat, 20 Mar 2021 12:32:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AF786B0080; Sat, 20 Mar 2021 12:32:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 1CFA96B007B for ; Sat, 20 Mar 2021 12:32:53 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C2F8F8249980 for ; Sat, 20 Mar 2021 16:32:52 +0000 (UTC) X-FDA: 77940796584.36.D8FA27B Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP id 5BBD4D5 for ; Sat, 20 Mar 2021 16:32:52 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9923961934; Sat, 20 Mar 2021 16:32:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1616257971; bh=WdUxKSETKcrjBZWfh67ufbdZG8tgIef5zeapBbsXIO4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BvJy91r/xPJQ8TUhms4zJXAeQ4JjQyRMHpSH+J/t+PshlcnFIyfVVma+n4FauXHNK JJmU1xS8qmmRUXGq8D+66H/D1R3jsEy31C8bUhiu/FPYERlHAiszKng4AExesa6RV8 Q/rQPfRcAx6QWZzZT7sEWsp4GBQ+kGqJywmKe0B8= Date: Sat, 20 Mar 2021 09:32:49 -0700 From: Andrew Morton To: Minchan Kim Cc: linux-mm , LKML , joaodias@google.com, surenb@google.com, cgoldswo@codeaurora.org, willy@infradead.org, mhocko@suse.com, david@redhat.com, vbabka@suse.cz, linux-fsdevel@vger.kernel.org, oliver.sang@intel.com Subject: Re: [PATCH v4 3/3] mm: fs: Invalidate BH LRU during page migration Message-Id: <20210320093249.2df740cd139449312211c452@linux-foundation.org> In-Reply-To: <20210319175127.886124-3-minchan@kernel.org> References: <20210319175127.886124-1-minchan@kernel.org> <20210319175127.886124-3-minchan@kernel.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 7zpdggtr9nfdjcucxb4e57qphnexqhuz X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5BBD4D5 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616257972-143287 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 19 Mar 2021 10:51:27 -0700 Minchan Kim wrote: > Pages containing buffer_heads that are in one of the per-CPU > buffer_head LRU caches will be pinned and thus cannot be migrated. > This can prevent CMA allocations from succeeding, which are often used > on platforms with co-processors (such as a DSP) that can only use > physically contiguous memory. It can also prevent memory > hot-unplugging from succeeding, which involves migrating at least > MIN_MEMORY_BLOCK_SIZE bytes of memory, which ranges from 8 MiB to 1 > GiB based on the architecture in use. > > Correspondingly, invalidate the BH LRU caches before a migration > starts and stop any buffer_head from being cached in the LRU caches, > until migration has finished. > > Tested-by: Oliver Sang > Reported-by: kernel test robot > Signed-off-by: Chris Goldsworthy > Signed-off-by: Minchan Kim The signoff chain ordering might mean that Chris was the primary author, but there is no From:him. Please clarify?