From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B9D5C433C1 for ; Sat, 20 Mar 2021 05:43:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 209B56197D for ; Sat, 20 Mar 2021 05:43:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 209B56197D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B4A6D8D000B; Sat, 20 Mar 2021 01:43:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFA286B0096; Sat, 20 Mar 2021 01:43:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99A898D000B; Sat, 20 Mar 2021 01:43:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id 7A7F46B0095 for ; Sat, 20 Mar 2021 01:43:21 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3BC16A741 for ; Sat, 20 Mar 2021 05:43:21 +0000 (UTC) X-FDA: 77939159802.35.F269FFB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id AF29480192D5 for ; Sat, 20 Mar 2021 05:43:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=4Y4aMF+8jf31XgvRHkLonra6ZVWq03ixGei9ymmXZRo=; b=ZvY5py3gh/LXbL9qrR31IkJ6qQ NN1zLehOFKScrydWvkWQrTE8CFCQwBLBZVv2jKAAg/vMn8WrGXAfhDj+CLPWZGShPKW/dIKdn5XSW 0TvWBHTR/+HXorEofXnmmW9HWUvxGo3CZ2R0LbEujhsufthWsSvpmsO1PxY4pmF7mwnpLf3hiTz2x Ox3FiVxB7avQPUYw4HMq3MxxbTO5gW1kDdhuQz3dfwwB929dASf7a9yFgVBHcZEPI4QyRdYGtey7v fcla+V00woGGKhkFHS7BUxcJAA6hSyx9eCFOYF6TBsQTpL37fuJ14O2v47HHQjxP8y7fLd63SxvM/ aa50DETg==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lNUNt-005SbL-UX; Sat, 20 Mar 2021 05:42:53 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: [PATCH v5 16/27] mm/filemap: Add lock_folio Date: Sat, 20 Mar 2021 05:40:53 +0000 Message-Id: <20210320054104.1300774-17-willy@infradead.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210320054104.1300774-1-willy@infradead.org> References: <20210320054104.1300774-1-willy@infradead.org> MIME-Version: 1.0 X-Stat-Signature: graqfpmr6wcwidenptqnp95myce7o4r3 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AF29480192D5 Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616219000-324569 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is like lock_page() but for use by callers who know they have a foli= o. Convert __lock_page() to be __lock_folio(). This saves one call to compound_head() per contended call to lock_page(). Saves 362 bytes of text; mostly from improved register allocation and inlining decisions. __lock_folio is 59 bytes while __lock_page was 79. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 24 +++++++++++++++++++----- mm/filemap.c | 29 +++++++++++++++-------------- 2 files changed, 34 insertions(+), 19 deletions(-) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index c211868086e0..c96ba0dfe111 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -693,7 +693,7 @@ static inline bool wake_page_match(struct wait_page_q= ueue *wait_page, return true; } =20 -extern void __lock_page(struct page *page); +void __lock_folio(struct folio *folio); extern int __lock_page_killable(struct page *page); extern int __lock_page_async(struct page *page, struct wait_page_queue *= wait); extern int __lock_page_or_retry(struct page *page, struct mm_struct *mm, @@ -702,13 +702,24 @@ void unlock_page(struct page *page); void unlock_folio(struct folio *folio); void unlock_page_private_2(struct page *page); =20 +static inline bool trylock_folio(struct folio *folio) +{ + return likely(!test_and_set_bit_lock(PG_locked, folio_flags(folio, 0)))= ; +} + /* * Return true if the page was successfully locked */ static inline int trylock_page(struct page *page) { - page =3D compound_head(page); - return (likely(!test_and_set_bit_lock(PG_locked, &page->flags))); + return trylock_folio(page_folio(page)); +} + +static inline void lock_folio(struct folio *folio) +{ + might_sleep(); + if (!trylock_folio(folio)) + __lock_folio(folio); } =20 /* @@ -716,9 +727,12 @@ static inline int trylock_page(struct page *page) */ static inline void lock_page(struct page *page) { + struct folio *folio; might_sleep(); - if (!trylock_page(page)) - __lock_page(page); + + folio =3D page_folio(page); + if (!trylock_folio(folio)) + __lock_folio(folio); } =20 /* diff --git a/mm/filemap.c b/mm/filemap.c index 47ac8126a12e..99c05e2c0eea 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1187,7 +1187,7 @@ static void wake_up_page(struct page *page, int bit= ) */ enum behavior { EXCLUSIVE, /* Hold ref to page and take the bit when woken, like - * __lock_page() waiting on then setting PG_locked. + * __lock_folio() waiting on then setting PG_locked. */ SHARED, /* Hold ref to page and check the bit when woken, like * wait_on_page_writeback() waiting on PG_writeback. @@ -1535,17 +1535,16 @@ void page_endio(struct page *page, bool is_write,= int err) EXPORT_SYMBOL_GPL(page_endio); =20 /** - * __lock_page - get a lock on the page, assuming we need to sleep to ge= t it - * @__page: the page to lock + * __lock_folio - Get a lock on the folio, assuming we need to sleep to = get it. + * @folio: The folio to lock */ -void __lock_page(struct page *__page) +void __lock_folio(struct folio *folio) { - struct page *page =3D compound_head(__page); - wait_queue_head_t *q =3D page_waitqueue(page); - wait_on_page_bit_common(q, page, PG_locked, TASK_UNINTERRUPTIBLE, + wait_queue_head_t *q =3D page_waitqueue(&folio->page); + wait_on_page_bit_common(q, &folio->page, PG_locked, TASK_UNINTERRUPTIBL= E, EXCLUSIVE); } -EXPORT_SYMBOL(__lock_page); +EXPORT_SYMBOL(__lock_folio); =20 int __lock_page_killable(struct page *__page) { @@ -1620,10 +1619,10 @@ int __lock_page_or_retry(struct page *page, struc= t mm_struct *mm, return 0; } } else { - __lock_page(page); + __lock_folio(page_folio(page)); } - return 1; =20 + return 1; } =20 /** @@ -2767,7 +2766,9 @@ loff_t mapping_seek_hole_data(struct address_space = *mapping, loff_t start, static int lock_page_maybe_drop_mmap(struct vm_fault *vmf, struct page *= page, struct file **fpin) { - if (trylock_page(page)) + struct folio *folio =3D page_folio(page); + + if (trylock_folio(folio)) return 1; =20 /* @@ -2780,7 +2781,7 @@ static int lock_page_maybe_drop_mmap(struct vm_faul= t *vmf, struct page *page, =20 *fpin =3D maybe_unlock_mmap_for_io(vmf, *fpin); if (vmf->flags & FAULT_FLAG_KILLABLE) { - if (__lock_page_killable(page)) { + if (__lock_page_killable(&folio->page)) { /* * We didn't have the right flags to drop the mmap_lock, * but all fault_handlers only check for fatal signals @@ -2792,11 +2793,11 @@ static int lock_page_maybe_drop_mmap(struct vm_fa= ult *vmf, struct page *page, return 0; } } else - __lock_page(page); + __lock_folio(folio); + return 1; } =20 - /* * Synchronous readahead happens when we don't even find a page in the p= age * cache at all. We don't want to perform IO under the mmap sem, so if = we have --=20 2.30.2