From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F7DEC433E0 for ; Fri, 19 Mar 2021 11:40:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9FDE064F6D for ; Fri, 19 Mar 2021 11:40:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FDE064F6D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DE7C06B006E; Fri, 19 Mar 2021 07:40:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D97906B0071; Fri, 19 Mar 2021 07:40:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C388D6B0072; Fri, 19 Mar 2021 07:40:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id A42706B006E for ; Fri, 19 Mar 2021 07:40:08 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4D92887DE for ; Fri, 19 Mar 2021 11:40:08 +0000 (UTC) X-FDA: 77936430096.03.0401327 Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by imf14.hostedemail.com (Postfix) with ESMTP id 3DEB7C0007C1 for ; Fri, 19 Mar 2021 11:40:04 +0000 (UTC) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 12JBbiIL004557; Fri, 19 Mar 2021 06:37:44 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 12JBbeiG004554; Fri, 19 Mar 2021 06:37:40 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 19 Mar 2021 06:37:40 -0500 From: Segher Boessenkool To: Christophe Leroy Cc: David Laight , Alexander Potapenko , Marco Elver , Andrew Morton , Dmitriy Vyukov , Andrey Konovalov , Jann Horn , LKML , Linux Memory Management List , kasan-dev Subject: Re: [PATCH mm] kfence: fix printk format for ptrdiff_t Message-ID: <20210319113740.GL16691@gate.crashing.org> References: <20210303121157.3430807-1-elver@google.com> <20210316153320.GF16691@gate.crashing.org> <3f624e5b-567d-70f9-322f-e721b2df508b@csgroup.eu> <6d4b370dc76543f2ba8ad7c6dcdfc7af@AcuMS.aculab.com> <001a139e-d4fa-2fd7-348f-173392210dfd@csgroup.eu> <4f7becfe2b6e4263be83b5ee461b5732@AcuMS.aculab.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Stat-Signature: i9jt57if8988tk484fmw9tt3gqggf7hp X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3DEB7C0007C1 Received-SPF: none (kernel.crashing.org>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=gate.crashing.org; client-ip=63.228.1.57 X-HE-DKIM-Result: none/none X-HE-Tag: 1616154004-312958 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 18, 2021 at 10:38:43AM +0100, Christophe Leroy wrote: > Yes it seems to be wrong. It was changed by commit d27dfd3887 ("Import > pre2.0.8"), so that's long time ago. Before that it was an 'int' for ppc32. > > gcc provides ptrdiff_t in stddef.h via __PTRDIFF_TYPE__ > gcc defined __PTRDIFF_TYPE__ as 'int' at build time. (On 32-bit PowerPC Linux.) > Should we fix it in arch/powerpc/include/uapi/asm/posix_types.h ? I think so, yes. > Anyway > 'long' and 'int' makes no functionnal difference on 32 bits so there should > be no impact for users if any. Except that long and int are different types, which causes errors like what you have here. There may be similar fallout from changing it back. Segher