From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: David Laight <David.Laight@ACULAB.COM>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dmitriy Vyukov <dvyukov@google.com>,
Andrey Konovalov <andreyknvl@google.com>,
Jann Horn <jannh@google.com>, LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
kasan-dev <kasan-dev@googlegroups.com>
Subject: Re: [PATCH mm] kfence: fix printk format for ptrdiff_t
Date: Fri, 19 Mar 2021 06:37:40 -0500 [thread overview]
Message-ID: <20210319113740.GL16691@gate.crashing.org> (raw)
In-Reply-To: <e4577151-bc73-5033-a9ed-114dd0c1aaaf@csgroup.eu>
On Thu, Mar 18, 2021 at 10:38:43AM +0100, Christophe Leroy wrote:
> Yes it seems to be wrong. It was changed by commit d27dfd3887 ("Import
> pre2.0.8"), so that's long time ago. Before that it was an 'int' for ppc32.
>
> gcc provides ptrdiff_t in stddef.h via __PTRDIFF_TYPE__
> gcc defined __PTRDIFF_TYPE__ as 'int' at build time.
(On 32-bit PowerPC Linux.)
> Should we fix it in arch/powerpc/include/uapi/asm/posix_types.h ?
I think so, yes.
> Anyway
> 'long' and 'int' makes no functionnal difference on 32 bits so there should
> be no impact for users if any.
Except that long and int are different types, which causes errors like
what you have here. There may be similar fallout from changing it back.
Segher
prev parent reply other threads:[~2021-03-19 11:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 12:11 Marco Elver
2021-03-03 12:27 ` Alexander Potapenko
2021-03-16 8:32 ` Christophe Leroy
2021-03-16 15:33 ` Segher Boessenkool
2021-03-16 15:40 ` Christophe Leroy
2021-03-17 12:51 ` David Laight
2021-03-17 17:35 ` Christophe Leroy
2021-03-18 9:14 ` David Laight
2021-03-18 9:38 ` Christophe Leroy
2021-03-19 11:37 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319113740.GL16691@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=David.Laight@ACULAB.COM \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=jannh@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox