From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25EEBC433E0 for ; Thu, 18 Mar 2021 17:08:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 94E6C60235 for ; Thu, 18 Mar 2021 17:08:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94E6C60235 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 13FD28D0001; Thu, 18 Mar 2021 13:08:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EFAA6B0075; Thu, 18 Mar 2021 13:08:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED2B78D0001; Thu, 18 Mar 2021 13:08:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id CEF9D6B0074 for ; Thu, 18 Mar 2021 13:08:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8751F180AC483 for ; Thu, 18 Mar 2021 17:08:47 +0000 (UTC) X-FDA: 77933629452.28.6A662E2 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf15.hostedemail.com (Postfix) with ESMTP id 9D8BAA00064C for ; Thu, 18 Mar 2021 17:08:32 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id n11so1856413pgm.12 for ; Thu, 18 Mar 2021 10:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ujDbuCzAN+YLNYYi8/HDfmgkpZHJOtMkPUu0MD84H14=; b=BFzQr8bJm/ZNyI6XHmJ4i3xuf4M+X5mAwVbg7D6tWIxiI8ZCIGyucPo90h/LfUox5/ bABSvLMpq0WKCgE2zsxgnc4y2/ccGXTJBSc6+TzeJkEqurYKBDN9T+76qt7EGpMHk//o 9PpZQBYHKUj3F6z3PWYRYxCOGAPDww7+p4CRc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ujDbuCzAN+YLNYYi8/HDfmgkpZHJOtMkPUu0MD84H14=; b=I6E88kjGOnNq+FQ9/aQwCAU/SiAxpTJ3eJUhPxVEUV5taE7C1hfDYLI24AFlOInpTg c4eayrGWFcX8ymipbmELH+D1ltQn7slrf2zi2EeNKYIczHtCoIDY7M5jpti8KdfzNeud HkeePYZTZQujIQtv0Eg4umaS+syWrOr+FRKRD3I2qEixPb4knOXRZA826quAd9dkDR0a VS87b45QvpMAGz95T56xE3zNhXXlWngvmKLGl14lGxKUepXWNdx3GUM+TMP1aGomFAep HqzP09dnfwhPc7FLUECO7zlJ5jVMxB0WHh6vT7kWVxifC+WChdvb4U0WQONUfxOG+NpL ItVw== X-Gm-Message-State: AOAM533WlrPkEB4tjiAvIcv5rMsEUcGTs3VYpAGJpJYjtOxBXiblM1GA G7dzuffakKhwjkEjnFF3CxIgRg== X-Google-Smtp-Source: ABdhPJycuac0e0voT5If8aAn21pk9Q9lKAxNTmoy4nmVnKUyybmi18zoXEcWvQWsGih0sCZ2JrRVbA== X-Received: by 2002:a05:6a00:2da:b029:202:7800:567 with SMTP id b26-20020a056a0002dab029020278000567mr4825125pft.71.1616087311096; Thu, 18 Mar 2021 10:08:31 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a8sm3004546pfk.138.2021.03.18.10.08.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 10:08:30 -0700 (PDT) Date: Thu, 18 Mar 2021 10:08:29 -0700 From: Kees Cook To: Vlastimil Babka Cc: Georgi Djakov , linux-mm@kvack.org, akpm@linux-foundation.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: Add slub_debug option to panic on memory corruption Message-ID: <202103181007.BD08B37D00@keescook> References: <20210309134720.29052-1-georgi.djakov@linaro.org> <390d8a2f-ead9-48a9-99eb-65c73bd18422@suse.cz> <6bfebf01-5f52-49bd-380b-04785c474c81@linaro.org> <8fd43de6-71e4-cfe7-8208-32753cf1c363@suse.cz> <202103172244.D5ADB06A96@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9D8BAA00064C X-Stat-Signature: x9jdsfuzijtwxo9gnj1husyb6caqrix5 Received-SPF: none (chromium.org>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=mail-pg1-f169.google.com; client-ip=209.85.215.169 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616087312-645119 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 18, 2021 at 01:56:05PM +0100, Vlastimil Babka wrote: > I was going to suggest adding a panic_on_taint parameter... but turns out it was > already added last year! And various memory corruption detections already use > TAINT_BAD_PAGE, including SLUB. > If anything's missing an add_taint() it can be added, and with the parameter you > should get what you want. Ah-ha! That works too. I hadn't seen that -- I wonder if I can wire some other hardening things up to that. (e.g. refactor BUG_ON_CORRUPTION finally.) -- Kees Cook