From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5559C433DB for ; Wed, 17 Mar 2021 13:07:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1CF2564F50 for ; Wed, 17 Mar 2021 13:07:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CF2564F50 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 45D076B006E; Wed, 17 Mar 2021 09:07:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4330E6B0070; Wed, 17 Mar 2021 09:07:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2ADFD6B0071; Wed, 17 Mar 2021 09:07:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id 13C9E6B006E for ; Wed, 17 Mar 2021 09:07:21 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BE55D3A91 for ; Wed, 17 Mar 2021 13:07:20 +0000 (UTC) X-FDA: 77929392240.14.FA6A829 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 8A45B3FD for ; Wed, 17 Mar 2021 13:07:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615986431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4pCvMxP4NIT/0WZCGZyEfttqqDQqWVhHTo9mUX6r6Us=; b=PRC9H+OHAH/l6DIX2UR4raHW4e95vdxZiJn23wXKxennpGM9twYs8XqYtQHfmcax93pfJ5 lwipr17fz/edNfTSCnrAUf9kE5b58Y02G0oT7i4zYIqoRNsKtUXrfoO0X6/1EzRLxxGzTS SIVv0HPxFjVA3sCp2s8+2l/OOWmXyzU= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-85-rM7pHXQZMxi2B0Pu69WInw-1; Wed, 17 Mar 2021 09:07:10 -0400 X-MC-Unique: rM7pHXQZMxi2B0Pu69WInw-1 Received: by mail-qv1-f69.google.com with SMTP id h12so27669739qvm.9 for ; Wed, 17 Mar 2021 06:07:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4pCvMxP4NIT/0WZCGZyEfttqqDQqWVhHTo9mUX6r6Us=; b=L+UfY06lp53HJ2ZhMgO+0hupBCyzCHSZ8h6GPv7c/+6/+/H8c9mTXmrYoORFnnzySM UxF5VTK5ettcX3u6OOvJalhLMLSaXaF0s8iq3feOoD+eLvfhSyd3+AgeTKe9SkeEK4Ln AsJWWoK/fJ6Tf5IlZU64gKBgilczZaPokMV30vskIYMPAf34moS+QcIC+uZErYovHpD/ btn1CFYs3vUeSK/Cn1ts7B8Y0459O+L18DkjqWYuHfPNRkUAzbmDKC4552Gb/xWXYo9V VwnT6NvGBYvEE1o/vJwaiBHcfZY9nA4cqmwNrnJHGjJ+bouoI4SvjdscVt5f27E85aKE z4aw== X-Gm-Message-State: AOAM5332HiKA3FLSgDNgQu/DF1U00AICgBm6937zESRkIzd8zE1S8qC0 fhLhUfCg4wOSgdoPhqfolOJ3GM7WLnG2H4RmgE5QghKWs+8SHXazRWwlIV2ovJx4FPvI37LRl/I nmGBRXeERgt0= X-Received: by 2002:a0c:ed2c:: with SMTP id u12mr5367403qvq.30.1615986429855; Wed, 17 Mar 2021 06:07:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYMD2/BnuHTuih57TnWV4OIvckXueEoBqtOwxHahW6iI9M1d4S5aF11gjV8e8yFC6H+7mSRg== X-Received: by 2002:a0c:ed2c:: with SMTP id u12mr5367281qvq.30.1615986428567; Wed, 17 Mar 2021 06:07:08 -0700 (PDT) Received: from xz-x1 ([142.126.89.138]) by smtp.gmail.com with ESMTPSA id b198sm17576424qkg.10.2021.03.17.06.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 06:07:08 -0700 (PDT) Date: Wed, 17 Mar 2021 09:07:06 -0400 From: Peter Xu To: Miaohe Lin Cc: akpm@linux-foundation.org, ziy@nvidia.com, willy@infradead.org, william.kucharski@oracle.com, vbabka@suse.cz, yulei.kernel@gmail.com, walken@google.com, aneesh.kumar@linux.ibm.com, rcampbell@nvidia.com, thomas_os@shipmail.org, yang.shi@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/6] mm/huge_memory.c: rework the function vma_adjust_trans_huge() Message-ID: <20210317130706.GJ395976@xz-x1> References: <20210316124007.20474-1-linmiaohe@huawei.com> <20210316124007.20474-2-linmiaohe@huawei.com> <20210316204034.GE395976@xz-x1> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8A45B3FD X-Stat-Signature: o4ia4987psgq1zc4473j9ytwbnc1i3xr Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615986433-30409 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 17, 2021 at 10:18:40AM +0800, Miaohe Lin wrote: > Hi: > On 2021/3/17 4:40, Peter Xu wrote: > > On Tue, Mar 16, 2021 at 08:40:02AM -0400, Miaohe Lin wrote: > >> +static inline void split_huge_pmd_if_needed(struct vm_area_struct *vma, unsigned long address) > >> +{ > >> + /* > >> + * If the new address isn't hpage aligned and it could previously > >> + * contain an hugepage: check if we need to split an huge pmd. > >> + */ > >> + if (address & ~HPAGE_PMD_MASK && > >> + range_in_vma(vma, address & HPAGE_PMD_MASK, > >> + (address & HPAGE_PMD_MASK) + HPAGE_PMD_SIZE)) > > > > Since you're at it, maybe use ALIGN/ALIGN_DOWN too against HPAGE_PMD_SIZE? > > > > Many thanks for reply. Sounds good. :) Do you mean this? > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index bff92dea5ab3..ae16a82da823 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2301,44 +2301,38 @@ void split_huge_pmd_address(struct vm_area_struct *vma, unsigned long address, > __split_huge_pmd(vma, pmd, address, freeze, page); > } > > +static inline void split_huge_pmd_if_needed(struct vm_area_struct *vma, unsigned long address) > +{ > + /* > + * If the new address isn't hpage aligned and it could previously > + * contain an hugepage: check if we need to split an huge pmd. > + */ > + if (!IS_ALIGNED(address, HPAGE_PMD_SIZE) && > + range_in_vma(vma, ALIGN_DOWN(address, HPAGE_PMD_SIZE), > + ALIGN(address, HPAGE_PMD_SIZE))) > + split_huge_pmd_address(vma, address, false, NULL); > +} > + Yes. Thanks, -- Peter Xu