From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A8EBC433DB for ; Tue, 16 Mar 2021 20:40:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A9EBD64F83 for ; Tue, 16 Mar 2021 20:40:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9EBD64F83 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2BED36B0036; Tue, 16 Mar 2021 16:40:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26EB56B006C; Tue, 16 Mar 2021 16:40:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EAA66B006E; Tue, 16 Mar 2021 16:40:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0227.hostedemail.com [216.40.44.227]) by kanga.kvack.org (Postfix) with ESMTP id E2CDA6B0036 for ; Tue, 16 Mar 2021 16:40:41 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9EFDA180AD837 for ; Tue, 16 Mar 2021 20:40:41 +0000 (UTC) X-FDA: 77926905882.09.933B261 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 11230A0009DC for ; Tue, 16 Mar 2021 20:40:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615927240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KX59dOzLD9yfpsQwlmLH6v3D1a9D72eLKsbU2fNBRlw=; b=XfsLDDR2tp7SzjWzOjtxOPUTqH8qdtgcAxMrLuOB/ph7MgnnI1G2DFIdPwUUyuFy1Xcq2D X42y3OW87oz5XlJbbZdq4qax+kFNoDaHQce/YSO1Mkie1lZGxYB+YQiLdorJxiH6X+lNdW vT2q9fgwUSstwW9t9TYvArY/5Rr2Ohk= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-ufhUEjh4PCWlgQVDpbC_gw-1; Tue, 16 Mar 2021 16:40:36 -0400 X-MC-Unique: ufhUEjh4PCWlgQVDpbC_gw-1 Received: by mail-qk1-f200.google.com with SMTP id b136so4456547qkc.20 for ; Tue, 16 Mar 2021 13:40:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KX59dOzLD9yfpsQwlmLH6v3D1a9D72eLKsbU2fNBRlw=; b=b78yEYat+OCz353vcdi3KyRFsYPP3/JY134DmuHWgQHxx4LTo/Cx3RD6+OF2agZPrG A5TxREJ2RHfgnVHThp7gAwNSFud/6cdg/6W2MyQjqXmnOX7UV8GqzW97q4TraIuI1kmH Z4KFdETJ0AhGBHvb4jI5wix8nF7lPkh41GS9SekwMqK8vmoe6ZAOE+0h7Hh7oA+56mjB DICGdOBV+wRuc2lPtwt11jhrMuPx9EmxwRetRcIjntPteLSytHO/Vothevoo6RW/Eoe+ hcsD1+jPxOdyVucC6yVwWDauhEkcMmkn0Qow9CktPrAtraR5Oo2PZ5HtTl+R4A2ByHCz akUw== X-Gm-Message-State: AOAM531vw3BnROTVG16lhCkaPhEQViClWXBgTb9ksONtcqEcUn4cIjAa aZvxjoezyRODRUan6hQZbMibDc8X3DoUuho+wMo0CiBNnq8KJJ6T/OsaBqzqkq4MMs5Q83yP4Cu jT66fr+F7DPg= X-Received: by 2002:a05:6214:1744:: with SMTP id dc4mr1409600qvb.40.1615927236154; Tue, 16 Mar 2021 13:40:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVLVDc/WCDRFl89Ty0f/G8CmwPqPDE9IkMBT7e8iNmC2afJ+CcJZClP7WD/nN5ZReBRCdYig== X-Received: by 2002:a05:6214:1744:: with SMTP id dc4mr1409575qvb.40.1615927235896; Tue, 16 Mar 2021 13:40:35 -0700 (PDT) Received: from xz-x1 ([142.126.89.138]) by smtp.gmail.com with ESMTPSA id 21sm15890887qkv.12.2021.03.16.13.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 13:40:35 -0700 (PDT) Date: Tue, 16 Mar 2021 16:40:34 -0400 From: Peter Xu To: Miaohe Lin Cc: akpm@linux-foundation.org, ziy@nvidia.com, willy@infradead.org, william.kucharski@oracle.com, vbabka@suse.cz, yulei.kernel@gmail.com, walken@google.com, aneesh.kumar@linux.ibm.com, rcampbell@nvidia.com, thomas_os@shipmail.org, yang.shi@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/6] mm/huge_memory.c: rework the function vma_adjust_trans_huge() Message-ID: <20210316204034.GE395976@xz-x1> References: <20210316124007.20474-1-linmiaohe@huawei.com> <20210316124007.20474-2-linmiaohe@huawei.com> MIME-Version: 1.0 In-Reply-To: <20210316124007.20474-2-linmiaohe@huawei.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 11230A0009DC X-Stat-Signature: 3j3fy8cnq6qn91azezsfoyzxjm5ob8b1 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615927240-321427 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 16, 2021 at 08:40:02AM -0400, Miaohe Lin wrote: > +static inline void split_huge_pmd_if_needed(struct vm_area_struct *vma, unsigned long address) > +{ > + /* > + * If the new address isn't hpage aligned and it could previously > + * contain an hugepage: check if we need to split an huge pmd. > + */ > + if (address & ~HPAGE_PMD_MASK && > + range_in_vma(vma, address & HPAGE_PMD_MASK, > + (address & HPAGE_PMD_MASK) + HPAGE_PMD_SIZE)) Since you're at it, maybe use ALIGN/ALIGN_DOWN too against HPAGE_PMD_SIZE? > + split_huge_pmd_address(vma, address, false, NULL); > +} -- Peter Xu