From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01030C433DB for ; Wed, 10 Mar 2021 19:40:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 97C8064EB2 for ; Wed, 10 Mar 2021 19:40:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97C8064EB2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EF9C18D0206; Wed, 10 Mar 2021 14:40:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E82BE8D01ED; Wed, 10 Mar 2021 14:40:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD5158D0206; Wed, 10 Mar 2021 14:40:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id ADF308D01ED for ; Wed, 10 Mar 2021 14:40:19 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 60146181AF5CC for ; Wed, 10 Mar 2021 19:40:19 +0000 (UTC) X-FDA: 77904980958.22.3AAB955 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf25.hostedemail.com (Postfix) with ESMTP id EE7B0600010C for ; Wed, 10 Mar 2021 19:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615405218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BjOJ0dCqhdIeLq3n4wL65+iP7wjuw6Bqt//gPOcAu8Y=; b=iIuHWLGztyiZnK2kuPkPg2N3VHeGwSR0mafzfGHLtubJkg38B5Og6ajPWKoFP1Z6kPCc7W p7wPUO/wNNyKWLnk8+plRL7lTGEHyFO0YPIQX4dzrGu6YSi5gpCNCLQO4Bakehy+VyWCLM auKCRqBth3NLfuGP+GUS6IsH02dlJVA= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-280-6dKWZqT7NVWi2ZIh1Nu3yQ-1; Wed, 10 Mar 2021 14:40:16 -0500 X-MC-Unique: 6dKWZqT7NVWi2ZIh1Nu3yQ-1 Received: by mail-qv1-f71.google.com with SMTP id o14so13497870qvn.18 for ; Wed, 10 Mar 2021 11:40:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BjOJ0dCqhdIeLq3n4wL65+iP7wjuw6Bqt//gPOcAu8Y=; b=IOatQUr1ZYXZuUJgdpodBS/dty4LvEibrV5E9vd5VB4nl3BDOQLMy3Ftu39ad6jxK8 7VPjq8j5hfbDkwovIKq9l8bluGvNWSU/eYPqnfyrKjjSDfBjwd2+oxNrNFFsy36XXJ/w CI3smq5zOn5NXu+ciG1Kc49bnZrc+dN0CRNiJL1ICRakYO7LCv3v1dE0825KqSzlMj2W TB8m8qOBDvtUmipTtxdfJDJI8YPcJ3ZZ0aU+u0Rd+wDNzFk7cQwmSBNYyemhMBYLIs0y S6q9jpVTZCufvtrlgg4U0sgCNm6fhvskgRoKLd5FOGj7GWxLkW3mf+vSyDntUoDV7nMN 15IQ== X-Gm-Message-State: AOAM533jDZajhFWxhPYYdq8LRRzdY9lyA0hassyUD2JC2O9wVeoKu891 7cBFv7FsKKHNLNn0sJiM6YmKf7fzv+ArVEbRTIK76lspmB0dA9amX3mcu8DQwoU3GgmHF3Zo/8I Zf8Z/Z5nlbVg= X-Received: by 2002:a37:9444:: with SMTP id w65mr4271285qkd.88.1615405216148; Wed, 10 Mar 2021 11:40:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJwOvTvsteE7aCYhpK18aeuxfi8A/1tgyWbU+qZS807rgYUZyq5xPe1e+WnK0uLo+Q/nmdz4ag== X-Received: by 2002:a37:9444:: with SMTP id w65mr4271265qkd.88.1615405215943; Wed, 10 Mar 2021 11:40:15 -0800 (PST) Received: from xz-x1 ([142.126.89.138]) by smtp.gmail.com with ESMTPSA id j6sm233211qkm.81.2021.03.10.11.40.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 11:40:15 -0800 (PST) Date: Wed, 10 Mar 2021 14:40:14 -0500 From: Peter Xu To: Mike Kravetz Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Axel Rasmussen , Naresh Kamboju Subject: Re: [PATCH] mm/hugetlb: Fix build with !ARCH_WANT_HUGE_PMD_SHARE Message-ID: <20210310194014.GE6530@xz-x1> References: <20210310185359.88297-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: xpnxgamrinnqioiwwx4n38ar8mfc54ne X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EE7B0600010C Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615405216-239238 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 10, 2021 at 11:21:50AM -0800, Mike Kravetz wrote: > On 3/10/21 10:53 AM, Peter Xu wrote: > > want_pmd_share() is undefined with !ARCH_WANT_HUGE_PMD_SHARE since it's put > > by accident into a "#ifdef ARCH_WANT_HUGE_PMD_SHARE" block. Moving it out > > won't work either since vma_shareable() is only defined within the block. > > Define it for !ARCH_WANT_HUGE_PMD_SHARE instead. > > > > Fixes: 5b109cc1cdcc ("hugetlb/userfaultfd: forbid huge pmd sharing when uffd enabled") > > That commit id is from Andrew's tree and I don't think it is stable. > There is a different id in the next tree. Not exactly sure how this is > supposed to be handled. I see - it'll be even better if this patch can be squashed into it. > > > Cc: Andrew Morton > > Cc: Mike Kravetz > > Cc: Axel Rasmussen > > Reported-by: Naresh Kamboju > > Tested-by: Naresh Kamboju > > Signed-off-by: Peter Xu > > --- > > mm/hugetlb.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > Thanks Peter, > Not your fault, but that header file is a bit of a mess. > > Reviewed-by: Mike Kravetz I'm still guilty on not noticing this before since I still could.. I think it gives me some more clue to make less such mistake in the future. Thanks for taking a quick look, Mike! -- Peter Xu