From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56FDC433DB for ; Wed, 10 Mar 2021 18:49:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C4B0C64DE5 for ; Wed, 10 Mar 2021 18:49:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4B0C64DE5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5470F8D01FB; Wed, 10 Mar 2021 13:49:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 51E208D01ED; Wed, 10 Mar 2021 13:49:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40D088D01FB; Wed, 10 Mar 2021 13:49:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 282758D01ED for ; Wed, 10 Mar 2021 13:49:33 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D084E8249980 for ; Wed, 10 Mar 2021 18:49:32 +0000 (UTC) X-FDA: 77904852984.02.2C082A4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id C4F912000D81 for ; Wed, 10 Mar 2021 18:49:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4HgOUtZioTDMKUvW4dyz8tRE+AffCXG+nsSseXdbPJk=; b=P1Bdb0fRml2tffwzopV3LbuQkD XiK+O7Tn0dk24d5j4uLS37+YCyyHyF+OzWpE2WQ4j21wKUZ3s1bWAoGqsSm+u1yBzszeCgZ6Ne+3t L2Z6/sUTX4fqGXjHSwHwgQTiz8zodMisx9vQj9oOS9jjijt1TuElXLy+NYrybZaR4m2GpepX84laF OOtPDEjY3QNJpRE04Os1zOb/8/dLOqIY4hEQ0EPZkBLdyi7nfVXQajaWWEplm25vUVt5Oqm4Npoxr JAR3BcPz0JxaHZYrxaw9zt6NkR+HjFDjkHE8/yvTlOLpjdyLqW6m7PQwWfmacwqh/smZmoyS4VNQQ QlTzrJIA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lK3tI-004PX6-LW; Wed, 10 Mar 2021 18:49:07 +0000 Date: Wed, 10 Mar 2021 18:49:04 +0000 From: Matthew Wilcox To: William Kucharski Cc: "dri-devel@lists.freedesktop.org" , "linux-fbdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Daniel Vetter , Ian Campbell , Jaya Kumar , Jani Nikula , Christoph Hellwig , "linux-mm@kvack.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH] fb_defio: Remove custom address_space_operations Message-ID: <20210310184904.GS3479805@casper.infradead.org> References: <20210310135128.846868-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: mjcmicysq4e6j5qnmft8otpaw58xy5e1 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C4F912000D81 Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615402166-826409 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 10, 2021 at 06:38:07PM +0000, William Kucharski wrote: > Looks good, just one super minor nit inline. > > @@ -228,13 +202,6 @@ void fb_deferred_io_cleanup(struct fb_info *info) > > > > BUG_ON(!fbdefio); > > cancel_delayed_work_sync(&info->deferred_work); > > - > > - /* clear out the mapping that we setup */ > > - for (i = 0 ; i < info->fix.smem_len; i += PAGE_SIZE) { > > - page = fb_deferred_io_page(info, i); > > - page->mapping = NULL; > > - } > > - > > mutex_destroy(&fbdefio->lock); > > } > > We no longer need the definition of "int i" right before the BUG_ON(). Huh. Usually gcc warns about that. let me figure that out and post a v2.