From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ECFDC433E0 for ; Wed, 10 Mar 2021 17:50:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1ACCC64F88 for ; Wed, 10 Mar 2021 17:50:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1ACCC64F88 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ABE468D01F0; Wed, 10 Mar 2021 12:50:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A46828D01ED; Wed, 10 Mar 2021 12:50:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90EAF8D01F0; Wed, 10 Mar 2021 12:50:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 772328D01ED for ; Wed, 10 Mar 2021 12:50:02 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 230236D81 for ; Wed, 10 Mar 2021 17:50:02 +0000 (UTC) X-FDA: 77904703044.07.80E20C5 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf02.hostedemail.com (Postfix) with ESMTP id 75269407F8FF for ; Wed, 10 Mar 2021 17:49:53 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 40EBFAC54; Wed, 10 Mar 2021 17:50:00 +0000 (UTC) Date: Wed, 10 Mar 2021 18:49:57 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/4] x86/vmemmap: Handle unpopulated sub-pmd ranges Message-ID: <20210310174953.GA16289@linux> References: <20210309174113.5597-1-osalvador@suse.de> <20210309174113.5597-4-osalvador@suse.de> <3471fe0e-d8f4-c8fe-2096-8d9c8b1ab5bc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3471fe0e-d8f4-c8fe-2096-8d9c8b1ab5bc@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: juhm4z6r96hr4tppqrjz5wfaabkz6fgq X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 75269407F8FF Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1615398593-137163 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 09, 2021 at 06:52:38PM +0100, David Hildenbrand wrote: > > -#define PAGE_INUSE 0xFD > > +#ifdef CONFIG_SPARSEMEM_VMEMMAP > > +#define PAGE_UNUSED 0xFD > > + > > +/* Returns true if the PMD is completely unused and thus it can be freed */ > > +static bool __meminit vmemmap_pmd_is_unused(unsigned long addr, unsigned long end) > > +{ > > I don't think the new name is any better. It implies that all it does is a > check - yet it actually clears the given range. (I prefer the old name, but > well, I came up with that, so what do I know :D ) Sorry, I did not mean to offend here. Something like: vmemmap_is_pmd_unused_after_clearing_it would be a bit better I guess. Tbh, both this and previous one looked fine to me, but I understand where Dave confusion was coming from, that is why I decided to rename it. Maybe a middle-ground would have been to expand the comment above. -- Oscar Salvador SUSE L3