From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D0CC433E9 for ; Wed, 10 Mar 2021 16:54:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 95FF764FCA for ; Wed, 10 Mar 2021 16:54:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95FF764FCA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2C10C8D01D0; Wed, 10 Mar 2021 11:54:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2986E8D01A6; Wed, 10 Mar 2021 11:54:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 187268D01D0; Wed, 10 Mar 2021 11:54:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id F03428D01A6 for ; Wed, 10 Mar 2021 11:54:51 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B5CC3181BD78C for ; Wed, 10 Mar 2021 16:54:51 +0000 (UTC) X-FDA: 77904563982.24.9205AF5 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf26.hostedemail.com (Postfix) with ESMTP id 8FD784080F4A for ; Wed, 10 Mar 2021 16:54:48 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 4452668B05; Wed, 10 Mar 2021 17:54:47 +0100 (CET) Date: Wed, 10 Mar 2021 17:54:47 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Vetter , Ian Campbell , Jaya Kumar , Jani Nikula , Christoph Hellwig , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fb_defio: Remove custom address_space_operations Message-ID: <20210310165447.GA18299@lst.de> References: <20210310135128.846868-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210310135128.846868-1-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8FD784080F4A X-Stat-Signature: 4bcezuhiw7jzfbr1whymkz41msnjuwao Received-SPF: none (lst.de>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=verein.lst.de; client-ip=213.95.11.211 X-HE-DKIM-Result: none/none X-HE-Tag: 1615395288-878669 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 10, 2021 at 01:51:28PM +0000, Matthew Wilcox (Oracle) wrote: > There's no need to give the page an address_space. Leaving the > page->mapping as NULL will cause the VM to handle set_page_dirty() > the same way that it's set now, and that was the only reason to > set the address_space in the first place. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good: Reviewed-by: Christoph Hellwig