From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7518AC433DB for ; Wed, 10 Mar 2021 05:50:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BB0EE64FE3 for ; Wed, 10 Mar 2021 05:50:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB0EE64FE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 295F08D016B; Wed, 10 Mar 2021 00:50:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 246928D0148; Wed, 10 Mar 2021 00:50:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 070698D016B; Wed, 10 Mar 2021 00:50:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id D9BE78D0148 for ; Wed, 10 Mar 2021 00:50:52 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8AC74824934B for ; Wed, 10 Mar 2021 05:50:52 +0000 (UTC) X-FDA: 77902890744.01.B648784 Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by imf02.hostedemail.com (Postfix) with ESMTP id E3FEE40001DE for ; Wed, 10 Mar 2021 05:50:42 +0000 (UTC) Received: from epcas5p4.samsung.com (unknown [182.195.41.42]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20210310055047epoutp020c49693bbb5a10aa0b73e23852f5b0f6~q5Th--Erp1870718707epoutp02N for ; Wed, 10 Mar 2021 05:50:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20210310055047epoutp020c49693bbb5a10aa0b73e23852f5b0f6~q5Th--Erp1870718707epoutp02N DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1615355447; bh=F6yiK3eZ5ZuvXhGR+yvTsN5lbrwcylNRqemOzFd7w64=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=c8nC9iiDqg5oxA/XyxKUMzZpeUKt5LarBnAZ3y+QTk46fSB1wVGvO1gVG9RTQwVt2 eQ0zlTRqmdlbOd5jDYJwjrDmntz6jztA2/ama9XHT7qY0Aut0KR9FUNThL391JJROl i8tg3dXKe+L0Lc5OnWgUpahVA+a7Jr98A4sk89mI= Received: from epsmges5p1new.samsung.com (unknown [182.195.42.73]) by epcas5p1.samsung.com (KnoxPortal) with ESMTP id 20210310055046epcas5p1a72bf00c8765de71d1a14e21eb42f1fd~q5ThgK8e33090830908epcas5p1x; Wed, 10 Mar 2021 05:50:46 +0000 (GMT) X-AuditID: b6c32a49-8bfff70000013d42-75-60485e3683e8 Received: from epcas5p2.samsung.com ( [182.195.41.40]) by epsmges5p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 6D.6A.15682.63E58406; Wed, 10 Mar 2021 14:50:46 +0900 (KST) Mime-Version: 1.0 Subject: RE: [PATCH v2] arm: print alloc free paths for address in registers Reply-To: maninder1.s@samsung.com From: Maninder Singh To: "linux@armlinux.org.uk" , "cl@linux.com" , "penberg@kernel.org" , "rientjes@google.com" , "iamjoonsoo.kim@lge.com" , "akpm@linux-foundation.org" , "vbabka@suse.cz" CC: Maninder Singh , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , AMIT SAHRAWAT , Vaneet Narang X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <1614239800-27549-1-git-send-email-maninder1.s@samsung.com> X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20210310055035epcms5p230de287f0daec198eb334b3348d07924@epcms5p2> Date: Wed, 10 Mar 2021 11:20:35 +0530 X-CMS-MailID: 20210310055035epcms5p230de287f0daec198eb334b3348d07924 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: REQ_APPROVE CMS-TYPE: 105P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJKsWRmVeSWpSXmKPExsWy7bCmhq5ZnEeCwbfTyhYXd6dazFm/hs3i +rc3jBYru5vZLDY9vsZqcXnXHDaLe2v+s1ocmrqX0eLw/DYWi7bP/1gt2pZsZLI4dHIuo8Xs xj5GB16Py9cuMnss2FTqsWlVJ5vHpk+T2D263l5h8jgx4zeLx5Mr05k8Ni+p9+jbsorR48yC I+wenzfJBXBHcdmkpOZklqUW6dslcGWc6X/DVHBVrOL//jNsDYw7hLoYOTkkBEwkJrw4zA5i CwnsZpR43e7ZxcjBwSsgKPF3hzBIWFjAR+LAzBeMECWKEhdmrGEEKREWMJD4tVUDJMwmoCex atceli5GLg4RgYNMErMuPANzmAV2M0nsPj+dFWIXr8SM9qcsELa0xPblW8GGcgp4SHx6M4UR Ii4qcXP1W3YY+/2x+VBxEYnWe2eZIWxBiQc/d0PFZSRWb+4FWyYh0M0o8fhHM1TzHEaJH0t8 IGxzid0b5oEt5hXwlfje3Q12EIuAqsTyE4+hDnKReLfoGNhQZgF5ie1v5zCDfMksoCmxfpc+ RImsxNRT65ggSvgken8/YYL5a8c8GFtVouXmBlaYHz9//Ag13kPiTcs2RpA7hQT6GSXW/ZjL PoFRYRYirGch2TwLYfMCRuZVjJKpBcW56anFpgWGeanlesWJucWleel6yfm5mxjBqU3Lcwfj 3Qcf9A4xMnEwHmKU4GBWEuH1O+6WIMSbklhZlVqUH19UmpNafIhRmoNFSZx3h8GDeCGB9MSS 1OzU1ILUIpgsEwenVAMTp8XDdwkFzJ9CE49a+syYKTlj1v93C29FXxWx0wr8t7tU78XjhHdv OzXvzj2xIUJ6k7VVX9UJgdNnop50rHgs3JlsyRPu++bLH3MbxXk1zAe7Es9V/Ztw2lazVuPu I6Pz4uufNJ99+d+k+5L01gMfLv562LNU9OLWs72XtDZb+K5YXpL255xgZeD/5H3Per84zZBK //F6x7d506eVdKeKrVp080bB7W1ux1/pxmvX33WfIBKrxrPTrYaHgTd42duk6iUhE17vuWUh YBua9F3lwJtKHy6jgEvHze8dK9Fgjt703rWAbW2E5fZfijvTyjc83BicuLaRXSD7DDf7ZtcG oe4zVeeS1OsKvrj6v56sqMRSnJFoqMVcVJwIAJkNKTfcAwAA X-CMS-RootMailID: 20210225075653epcas5p3d9551f01177d0c851c9c37f6ae84f38d References: <1614239800-27549-1-git-send-email-maninder1.s@samsung.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E3FEE40001DE X-Stat-Signature: yqkotg9ufc77ijgmpfprbkd37no3geqe Received-SPF: none (samsung.com>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=mailout2.samsung.com; client-ip=203.254.224.25 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615355442-48457 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Any comments or updates? >Sender : Maninder Singh Engineer/Platform S/W Group /SRI-Delhi/Samsung Electronics >Date : 2021-02-25 13:57 (GMT+5:30) >Title : [PATCH v2] arm: print alloc free paths for address in registers > >In case of "Use After Free" kernel OOPs, free path of object >is required to debug futher. >And in most of cases object address is present in one of registers. > >Thus check for register address and if it belongs to slab, >print its alloc and free path. > >e.g. in below issue register r6 belongs to slab, and use after free issue >occurred on one of its derefer values: > >[ 124.310386] (ptrval) >[ 124.312647] 8<--- cut here --- >[ 124.313761] Unable to handle kernel paging request at virtual address 6b6b6b6f >[ 124.315972] pgd = (ptrval) >... >[ 124.328290] pc : [] lr : [] psr: 60000013 >[ 124.330349] sp : c8993d28 ip : 0000bff4 fp : c8ae2020 >[ 124.332071] r10: 00000000 r9 : 00000001 r8 : c1804cc8 >[ 124.333803] r7 : 00000000 r6 : c8ae9180 r5 : c1804a80 r4 : c8ae2008 >[ 124.335936] r3 : 6b6b6b6b r2 : 315049d6 r1 : 2d867000 r0 : c1396584 >.. >[ 124.365233] register r6: c8ae9180 belongs to slab object >[ 124.366364] INFO: Allocated in meminfo_proc_show+0x3c/0x500 age=1 cpu=0 pid=69 >[ 124.367545] meminfo_proc_show+0x3c/0x500 >[ 124.368271] seq_read_iter+0x10c/0x4bc >[ 124.368994] proc_reg_read_iter+0x74/0xa8 >[ 124.369712] generic_file_splice_read+0xe8/0x178 >[ 124.370496] splice_direct_to_actor+0xe0/0x2b8 >[ 124.371261] do_splice_direct+0xa4/0xdc >[ 124.371917] do_sendfile+0x1c4/0x3ec >[ 124.372550] sys_sendfile64+0x128/0x130 >[ 124.373109] ret_fast_syscall+0x0/0x54 >[ 124.373664] 0xbe9a2de4 >[ 124.374081] INFO: Freed in meminfo_proc_show+0x5c/0x500 age=1 cpu=0 pid=69 >[ 124.374933] meminfo_proc_show+0x5c/0x500 >[ 124.375485] seq_read_iter+0x10c/0x4bc >[ 124.376020] proc_reg_read_iter+0x74/0xa8 >[ 124.376643] generic_file_splice_read+0xe8/0x178 >[ 124.377331] splice_direct_to_actor+0xe0/0x2b8 >[ 124.378022] do_splice_direct+0xa4/0xdc >[ 124.378633] do_sendfile+0x1c4/0x3ec >[ 124.379220] sys_sendfile64+0x128/0x130 >[ 124.379822] ret_fast_syscall+0x0/0x54 >[ 124.380421] 0xbe9a2de4 > >Co-developed-by: Vaneet Narang >Signed-off-by: Vaneet Narang >Signed-off-by: Maninder Singh >--- >v1 -> v2: do address sanity with virt_addr_valid > > arch/arm/include/asm/bug.h | 1 + > arch/arm/kernel/process.c | 18 ++++++++++++++++++ > arch/arm/kernel/traps.c | 1 + > include/linux/slab.h | 14 ++++++++++++++ > mm/slab.h | 7 ------- > mm/slub.c | 18 ++++++++++++++++++ > 6 files changed, 52 insertions(+), 7 deletions(-) Thanks, Maninder Singh