From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7A1EC433DB for ; Mon, 8 Mar 2021 07:10:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 13DFE65146 for ; Mon, 8 Mar 2021 07:10:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13DFE65146 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8C0CB6B00AA; Mon, 8 Mar 2021 02:10:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 893F66B00AB; Mon, 8 Mar 2021 02:10:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 737B06B00AC; Mon, 8 Mar 2021 02:10:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id 583216B00AA for ; Mon, 8 Mar 2021 02:10:48 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1EE9C364C for ; Mon, 8 Mar 2021 07:10:48 +0000 (UTC) X-FDA: 77895834576.29.C67905A Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf10.hostedemail.com (Postfix) with ESMTP id A57A6407F8DF for ; Mon, 8 Mar 2021 07:10:44 +0000 (UTC) IronPort-SDR: K7hRzHUk2Mc0IXNxu88FNb7I1ChPB5Oa9lIkmy7jXgMqCw1ZP1teY5yFAoZIEHOmMRz4GvrPWS G4H6X4w5NrAQ== X-IronPort-AV: E=McAfee;i="6000,8403,9916"; a="188031661" X-IronPort-AV: E=Sophos;i="5.81,231,1610438400"; d="scan'208";a="188031661" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2021 23:10:45 -0800 IronPort-SDR: vmSFpWMwUiJEu+91myett37wV7ptmY1pIkTehUyefwi8OTEYKED1uBbQyIWTwk2vzbRG1dGUiU KnzvOQKxTP+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,231,1610438400"; d="scan'208";a="447038948" Received: from lkp-server01.sh.intel.com (HELO 3e992a48ca98) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 07 Mar 2021 23:10:42 -0800 Received: from kbuild by 3e992a48ca98 with local (Exim 4.92) (envelope-from ) id 1lJA2M-0000qo-6m; Mon, 08 Mar 2021 07:10:42 +0000 Date: Mon, 8 Mar 2021 15:09:51 +0800 From: kernel test robot To: Greg Kroah-Hartman Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, Peter Chen , Felipe Balbi , Jens Axboe , Andrew Morton , Linux Memory Management List , "Gustavo A. R. Silva" , Lee Jones , Vamsi Krishna Samavedam , Sriharsha Allenki Subject: [PATCH] USB: gadget: f_fs: fix memdup_user.cocci warnings Message-ID: <20210308070951.GA83949@8a16bdd473dc> References: <202103081519.ZUP3wXzn-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202103081519.ZUP3wXzn-lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: y5gb496s71wgb8myt8zubkcmgfw1hydf X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A57A6407F8DF Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mga03.intel.com; client-ip=134.134.136.65 X-HE-DKIM-Result: none/none X-HE-Tag: 1615187444-462294 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: kernel test robot drivers/usb/gadget/function/f_fs.c:3829:8-15: WARNING opportunity for memdup_user Use memdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives Generated by: scripts/coccinelle/api/memdup_user.cocci Fixes: 8704fd73bf56 ("USB: gadget: f_fs: remove likely/unlikely") Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 144c79ef33536b4ecb4951e07dbc1f2b7fa99d32 commit: 8704fd73bf5658bf4b827643f7f526481082d83f USB: gadget: f_fs: remove likely/unlikely f_fs.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -3826,14 +3826,9 @@ static char *ffs_prepare_buffer(const ch if (!len) return NULL; - data = kmalloc(len, GFP_KERNEL); - if (!data) - return ERR_PTR(-ENOMEM); - - if (copy_from_user(data, buf, len)) { - kfree(data); - return ERR_PTR(-EFAULT); - } + data = memdup_user(buf, len); + if (IS_ERR(data)) + return ERR_PTR(PTR_ERR(data)); pr_vdebug("Buffer from user space:\n"); ffs_dump_mem("", data, len);