From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79093C4332E for ; Thu, 4 Mar 2021 15:50:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 029F160230 for ; Thu, 4 Mar 2021 15:50:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 029F160230 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7D57A6B0006; Thu, 4 Mar 2021 10:50:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ADDE6B0008; Thu, 4 Mar 2021 10:50:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64F866B000D; Thu, 4 Mar 2021 10:50:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 400DA6B0006 for ; Thu, 4 Mar 2021 10:50:28 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D9FED181B049D for ; Thu, 4 Mar 2021 15:50:27 +0000 (UTC) X-FDA: 77882628894.16.71DBB44 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf27.hostedemail.com (Postfix) with ESMTP id DF55A801A819 for ; Thu, 4 Mar 2021 15:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614873024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kQt2Y0bDQy5kebuxLoR8afLNrZ5ZNUK/gHrzh5pdHhA=; b=MLDxIBFJCtqpn6uneNZFenPeDDQS5zDgH9GW+9nb1s99KpEcNYj8PmwT6uWuoskwozGu58 hKmbG1rHghKl+fJf38/P16mTcBJuRM2hmmOYFH+EZ94C2iF/jnaTsEa6LaH/5im71oeVBM VpYMGsmLcsnCYGNxesBnCN8G7SU+1Yc= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-449-5RSlW7vFNQyAkz0qHOTwdA-1; Thu, 04 Mar 2021 10:50:22 -0500 X-MC-Unique: 5RSlW7vFNQyAkz0qHOTwdA-1 Received: by mail-qv1-f69.google.com with SMTP id iy2so10077138qvb.22 for ; Thu, 04 Mar 2021 07:50:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kQt2Y0bDQy5kebuxLoR8afLNrZ5ZNUK/gHrzh5pdHhA=; b=ubTaGEwCDfSFns7lXCx91UwewRC/mn6qrZGINN5YQGzXeF93Ubay/YbL4g2orJCtuu ESIn3Z8VqUozZ7Bso+1gS/WzmddlPTygtOoOFxkgKy8s6HJ0Q11u/7bnFQswhpI48pRr pj0+4c0ZK9mJVsZcStPEHwLOuwRRgKGnydMRpQWJxJEQGarTg7dUJFsr+3wFGCbTbxUl h9aaXQ4yO3pUrkDJVuSuC1HYSqPU9VE+u3KM+lGWqNg9XBjLUZsTH8BQPkvTJjcZxurF 95KKVz7JaypcKftvVs5WAfeJaOkbcbHppBG2yS+p02oTIaJr4AvXexAEdGaJ/vl6b4XL 7rSw== X-Gm-Message-State: AOAM531QEx3+cC5gzwbkC5Z+uqp0tSo+UUlQXeLBgq6wpZXOd5M0nCAw kAaZ8rbS1/Tz8yFzD5/TNT8v8pKksRDBd2SE1heW2JaEdAEspaW7qJXBLYsUkqHxbqwQdAHalil 3TrrGXuOIPz8= X-Received: by 2002:a05:6214:18d2:: with SMTP id cy18mr4719971qvb.50.1614873022172; Thu, 04 Mar 2021 07:50:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJx3l8J0s9E9vj9Tchr6GSaSM3eRe+MoXYdmMgBMHvxK4rTrHy2WwPSYwx+R0iUueuirWX2d4A== X-Received: by 2002:a05:6214:18d2:: with SMTP id cy18mr4719956qvb.50.1614873021927; Thu, 04 Mar 2021 07:50:21 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-25-174-95-95-253.dsl.bell.ca. [174.95.95.253]) by smtp.gmail.com with ESMTPSA id c27sm3389693qko.71.2021.03.04.07.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 07:50:21 -0800 (PST) Date: Thu, 4 Mar 2021 10:50:19 -0500 From: Peter Xu To: "Alejandro Colomar (man-pages)" Cc: Mike Rapoport , Nadav Amit , linux-kernel@vger.kernel.org, Linux MM Mailing List , Axel Rasmussen , Andrea Arcangeli , Andrew Morton , Michael Kerrisk , linux-man@vger.kernel.org Subject: Re: [PATCH 1/4] userfaultfd.2: Add UFFD_FEATURE_THREAD_ID docs Message-ID: <20210304155019.GX397383@xz-x1> References: <20210304015947.517713-1-peterx@redhat.com> <20210304015947.517713-2-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DF55A801A819 X-Stat-Signature: jap35m3tyzg5im96ucsyxuid9m16cfdr Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614873023-998168 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 04, 2021 at 10:22:18AM +0100, Alejandro Colomar (man-pages) wrote: > Hello Peter, Hi, Alex, > > On 3/4/21 2:59 AM, Peter Xu wrote: > > UFFD_FEATURE_THREAD_ID is supported since Linux 4.14. > > > > Signed-off-by: Peter Xu > > --- > > man2/userfaultfd.2 | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/man2/userfaultfd.2 b/man2/userfaultfd.2 > > index e7dc9f813..2d14effc6 100644 > > --- a/man2/userfaultfd.2 > > +++ b/man2/userfaultfd.2 > > @@ -77,6 +77,12 @@ When the last file descriptor referring to a userfaultfd object is closed, > > all memory ranges that were registered with the object are unregistered > > and unread events are flushed. > > .\" > > +.PP > > +Since Linux 4.14, userfaultfd page fault message can selectively embed fault > > +thread ID information into the fault message. One needs to enable this feature > > +explicitly using the > > +.BR UFFD_FEATURE_THREAD_ID > > This should use [.B] and not [.BR]. > .BR is for alternate Bold and Roman. > .B is for bold. > > (There are more appearances of this in the other patches.) Yeah I got a bit confused when differenciating those two, since I also see similar usage, e.g.: .BR O_CLOEXEC I'll fix all of them appeared in current patchset. Let me know if you also want me to fix all the existing uses of ".BR" too where ".B" would suffice. Otherwise I won't touch them since I can't say they're wrong either (I think most of them should generate the same output with either ".BR" or ".B" if there's only one word?). Thanks, -- Peter Xu