From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D005CC433E0 for ; Thu, 4 Mar 2021 06:10:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1FE7F64EFD for ; Thu, 4 Mar 2021 06:10:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FE7F64EFD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6C06D6B0005; Thu, 4 Mar 2021 01:10:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 697566B0006; Thu, 4 Mar 2021 01:10:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55F296B0007; Thu, 4 Mar 2021 01:10:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id 3CC506B0005 for ; Thu, 4 Mar 2021 01:10:08 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id EA5F3181A4E35 for ; Thu, 4 Mar 2021 06:10:07 +0000 (UTC) X-FDA: 77881166454.25.AC02E14 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf30.hostedemail.com (Postfix) with ESMTP id 3F55EE0011E0 for ; Thu, 4 Mar 2021 06:10:02 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C74A664EF4; Thu, 4 Mar 2021 06:09:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614838198; bh=+nG0rfRK4n053IrGSGk0WPCLcLlRFEry9QnCOUM0CYw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cVCe3irbldmwk3a04xwPK2/EONslovg8z5/44TFiwXQSxoXxLnGCkh/zTrJTB4YNu 7d20tNK6YxmjRWHf4Vu44ZK15h0tgqlevOjfhSaYK4krBokghFVMfZCSaRXIPracy8 JgUQP5UV4eQZ+k5M77d5WqSoDLOHFSIhQ4KEZLOM= Date: Wed, 3 Mar 2021 22:09:57 -0800 From: Andrew Morton To: Minchan Kim Cc: linux-mm , LKML , joaodias@google.com, willy@infradead.org, surenb@google.com, Greg Kroah-Hartman , John Hubbard Subject: Re: [PATCH v3] mm: cma: support sysfs Message-Id: <20210303220957.0525de2aebc2c55ad9435cdc@linux-foundation.org> In-Reply-To: References: <20210303205053.2906924-1-minchan@kernel.org> <20210303144449.aa69518bfbaec9c71f799dc7@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: itfgxfdjx4ibsfjgfafc778jo7smwzga X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3F55EE0011E0 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614838202-450323 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 3 Mar 2021 17:38:12 -0800 Minchan Kim wrote: > > > #endif > > > char name[CMA_MAX_NAME]; > > > +#ifdef CONFIG_CMA_SYSFS > > > + struct cma_stat *stat; > > > +#endif > > > }; > > > > Why aren't the stat fields simply placed directly into struct cma_stat? > > It have a related long discussion. > https://lore.kernel.org/linux-mm/YCIoHBGELFWAyfMi@kroah.com/ > https://lore.kernel.org/linux-mm/YCLLKDEQ4NYqb5Y5@kroah.com/ > > TLDR - Greg really want to see kobject stuff working as dynamic > property. Please add to changelog? > > > > ? > > > > > + if (!cma_stats) { > > > + pr_err("failed to create cma_stats\n"); > > > > Probably unneeded - the ENOMEM stack backtrace will point straight here. > > I failed to find the point you mentioned to print backtrace. > Where code do you mean to dump the backtrace? The thing which __GFP_NOWARN disables.